List:Commits« Previous MessageNext Message »
From:Andrei Elkin Date:November 17 2006 9:44pm
Subject:bk commit into 5.1 tree (aelkin:1.2367) BUG#24403
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of elkin. When elkin does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-11-17 23:44:14+02:00, aelkin@stripped +1 -0
  Bug #24403 valgrind complained on uninited st_table, rbr + innodb
    
    open_table_from_share did not initialize table->record members. that was
    interpreted as the error by valgrind.
    
    Fixed with bzero-ing the members if compilation with -DHAVE_purify.

  sql/table.cc@stripped, 2006-11-17 23:44:06+02:00, aelkin@stripped +3 -1
    zeroing memory allocated for table->record[]

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	aelkin
# Host:	dsl-hkibras-fe30f900-107.dhcp.inet.fi
# Root:	/home/elkin/MySQL/BARE/5.1-new

--- 1.252/sql/table.cc	2006-11-17 23:44:31 +02:00
+++ 1.253/sql/table.cc	2006-11-17 23:44:31 +02:00
@@ -1377,7 +1377,9 @@ int open_table_from_share(THD *thd, TABL
   if (!(record= (byte*) alloc_root(&outparam->mem_root,
                                    share->rec_buff_length * records)))
     goto err;                                   /* purecov: inspected */
-
+#ifdef HAVE_purify
+     bzero(record, share->rec_buff_length * records);
+#endif  
   if (records == 0)
   {
     /* We are probably in hard repair, and the buffers should not be used */
Thread
bk commit into 5.1 tree (aelkin:1.2367) BUG#24403Andrei Elkin17 Nov