bk commit into 5.0 tree (msvensson:1.2316) BUG#24274

[msvensson]

Below is the list of changes that have just been committed into a local
5.0 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-11-17 11:01:09+01:00, msvensson@neptunus.(none) +2 -0
  Bug#24274  option "--big-test" of mysql-test-run.pl does not work anymore
   - Set environment variable BIG_TEST when using --big-test
   - Skip comment lines when looking for features a test case supports.

  mysql-test/lib/mtr_cases.pl@stripped, 2006-11-17 11:01:07+01:00, msvensson@neptunus.(none) +3 -0
    Skip all lines that start with # when looking for features required by the test case

  mysql-test/mysql-test-run.pl@stripped, 2006-11-17 11:01:07+01:00, msvensson@neptunus.(none) +11 -9
    Set environment variable BIG_TEST if option --big-test passed.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	neptunus.(none)
# Root:	/home/msvensson/mysql/mysql-5.0-maint

--- 1.31/mysql-test/lib/mtr_cases.pl	2006-11-17 11:01:16 +01:00
+++ 1.32/mysql-test/lib/mtr_cases.pl	2006-11-17 11:01:16 +01:00
@@ -593,6 +593,9 @@ sub mtr_options_from_test_file($$) {
 
   while ( my $line= <$F> )
   {
+    # Skip line if it start's with #
+    next if ( $line =~ /^#/ );
+
     # Match this line against tag in "tags" array
     foreach my $tag (@tags)
     {

--- 1.155/mysql-test/mysql-test-run.pl	2006-11-17 11:01:16 +01:00
+++ 1.156/mysql-test/mysql-test-run.pl	2006-11-17 11:01:16 +01:00
@@ -164,7 +164,7 @@ our $exe_libtool;
 
 our $opt_bench= 0;
 our $opt_small_bench= 0;
-our $opt_big_test= 0;            # Send --big-test to mysqltest
+our $opt_big_test= 0;
 
 our @opt_extra_mysqld_opt;
 
@@ -920,6 +920,14 @@ sub command_line_setup () {
   }
 
   # --------------------------------------------------------------------------
+  # Big test flags
+  # --------------------------------------------------------------------------
+  if ( $opt_big_test )
+  {
+    $ENV{'BIG_TEST'}= 1;
+  }
+
+  # --------------------------------------------------------------------------
   # Gcov flag
   # --------------------------------------------------------------------------
   if ( $opt_gcov and ! $opt_source_dist )
@@ -4370,11 +4378,6 @@ sub run_mysqltest ($) {
     mtr_add_arg($args, "--timer-file=%s/log/timer", $opt_vardir);
   }
 
-  if ( $opt_big_test )
-  {
-    mtr_add_arg($args, "--big-test");
-  }
-
   if ( $opt_compress )
   {
     mtr_add_arg($args, "--compress");
@@ -4765,9 +4768,8 @@ Options to control what test suites or c
   skip-rpl              Skip the replication test cases.
   skip-im               Don't start IM, and skip the IM test cases
   skip-test=PREFIX      Skip test cases which name are prefixed with PREFIX
-  big-test              Pass "--big-test" to mysqltest which will set the
-                        environment variable BIG_TEST, which can be checked
-                        from test cases.
+  big-test              Set the environment variable BIG_TEST, which can be
+                        checked from test cases.
 
 Options that specify ports