From: Date: November 8 2006 12:26am
Subject: bk commit into 5.0 tree (sergefp:1.2300) BUG#24056
List-Archive: http://lists.mysql.com/commits/15001
X-Bug: 24056
Message-Id: <20061107232656.59D0DBBC001@pylon64.mylan>

Below is the list of changes that have just been committed into a local
5.0 repository of psergey. When psergey does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-11-08 02:26:50+03:00, sergefp@stripped +1 -0
  BUG#24056: Crash in subquery:
  Don't assume that condition that was pushed down into subquery has 
  produced exactly one KEY_FIELD element - it could produce several or
  none at all, handle all of those cases.

  sql/sql_select.cc@stripped, 2006-11-08 02:26:47+03:00, sergefp@stripped +3 -1
    BUG#24056: Crash in subquery:
    Don't assume that condition that was pushed down into subquery has 
    produced exactly one KEY_FIELD element - it could produce several or
    none at all, handle all of those cases.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	sergefp
# Host:	pylon64.mylan
# Root:	/home/psergey/mysql-5.0-bug8804-pfix

--- 1.469/sql/sql_select.cc	2006-11-08 02:26:55 +03:00
+++ 1.470/sql/sql_select.cc	2006-11-08 02:26:55 +03:00
@@ -2951,10 +2951,12 @@
           join->unit->item->substype() == Item_subselect::IN_SUBS &&
           !join->unit->first_select()->next_select())
       {
+        KEY_FIELD *save= *key_fields;
         add_key_fields(join, key_fields, and_level, cond, usable_tables,
                        sargables);
         // Indicate that this ref access candidate is for subquery lookup:
-        (*key_fields)[-1].outer_ref= TRUE;
+        for (; save != *key_fields; save++)
+          save->outer_ref= TRUE;
       }
       return;
     }