Re: Connector/ODBC 5 commit: r652 - trunk/SDK/MYSQLPlus/Library

[Jess Balint]

Looks good.

Was this a bug in our driver, or something that changed in MySQL in
regards to the column numbers?

Thanks for removing the printf(), is this something we should try to
keep out of Svn commits?

Jess

On Sun, Nov 05, 2006 at 12:42:03AM +0100, pharvey@stripped wrote:
> Modified:
>    trunk/SDK/MYSQLPlus/Library/MResultPlus.cpp
> Log:
> FIX: Corrected incorrect col index within SQLStatistics. Many more tables can now be
> linked into MS Access.
> 
> Modified: trunk/SDK/MYSQLPlus/Library/MResultPlus.cpp
> ===================================================================
> --- trunk/SDK/MYSQLPlus/Library/MResultPlus.cpp	2006-11-04 21:46:38 UTC (rev 651)
> +++ trunk/SDK/MYSQLPlus/Library/MResultPlus.cpp	2006-11-04 23:42:03 UTC (rev 652)
> @@ -696,7 +696,6 @@
>                  getDiagnostic()->doAppend( MDiagnostic::STATE_01000, 0,  QString(
> "Unhandled index type (%1)" ).arg( stringType ) );
>                  nType = SQL_INDEX_OTHER;
>              }
> -printf( "[PAH][%s][%s][%d] %s\n", __FILE__, __FUNCTION__, __LINE__, pRow[9] );
>  
>              /*! \note as i recall we can get FILTER_CONDITION from COMMENT - but not
> 100% of the time so perhaps forget it or perhaps try to be smart? */
>              doAppendStatistics( pRow[4],    // catalog - we put MySQL schema in
> here
> @@ -706,8 +705,8 @@
>                                  nType,      // type
>                                  pRow[6],    // ordinal
>                                  pRow[7],    // column
> -                                pRow[9],    // AscDesc,
> -                                pRow[10] ); // Cardinality
> +                                pRow[8],    // AscDesc,
> +                                pRow[9] ); // Cardinality
>          }
>  
>          mysql_free_result( pResult ); 
> 
> 
> -- 
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe:    http://lists.mysql.com/commits?unsub=1