From: Date: November 3 2006 12:11pm
Subject: bk commit into 5.1 tree (gni:1.2290) BUG#19146
List-Archive: http://lists.mysql.com/commits/14796
X-Bug: 19146
Message-Id: <200611031111.kA3BB228024472@dev3-127>

Below is the list of changes that have just been committed into a local
5.1 repository of root. When root does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-11-03 19:08:57+08:00, gni@dev3-127.(none) +2 -0
  BUG #19146 If Backup parameters incorrectly set, the data nodes can't start.

  storage/ndb/src/kernel/blocks/backup/Backup.cpp@stripped, 2006-11-03 19:08:55+08:00, gni@dev3-127.(none) +12 -0
    If FailedToSetupFsBuffers in BACKUP block, it will send back DEFINE_BACKUP_REF to LQH.

  storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp@stripped, 2006-11-03 19:08:55+08:00, gni@dev3-127.(none) +20 -0
    If get DEFINE_BACKUP_REF signal , LQH will crash and give some messages in error log. 

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	gni
# Host:	dev3-127.(none)
# Root:	/mnt/mysql/home/ngb/mysql-5.1/mysql-5.1-bug19146

--- 1.52/storage/ndb/src/kernel/blocks/backup/Backup.cpp	2006-11-03 19:10:03 +08:00
+++ 1.53/storage/ndb/src/kernel/blocks/backup/Backup.cpp	2006-11-03 19:10:03 +08:00
@@ -2373,6 +2373,18 @@
   {
     jam();
 
+    if (ptr.p->ctlFilePtr == RNIL) {
+      ptr.p->m_gsn = GSN_DEFINE_BACKUP_REF;
+      ndbrequire(ptr.p->errorCode != 0);
+      DefineBackupRef* ref = (DefineBackupRef*)signal->getDataPtrSend();
+      ref->backupId = ptr.p->backupId;
+      ref->backupPtr = ptr.i;
+      ref->errorCode = ptr.p->errorCode;
+      ref->nodeId = getOwnNodeId();
+      sendSignal(ptr.p->masterRef, GSN_DEFINE_BACKUP_REF, signal,
+                 DefineBackupRef::SignalLength, JBB);
+      return;
+    }
     BackupFilePtr filePtr;
     ptr.p->files.getPtr(filePtr, ptr.p->ctlFilePtr);
     if (filePtr.p->m_flags & BackupFile::BF_LCP_META)

--- 1.122/storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp	2006-11-03 19:10:03 +08:00
+++ 1.123/storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp	2006-11-03 19:10:03 +08:00
@@ -566,6 +566,26 @@
 {
   jamEntry();
   m_backup_ptr = RNIL;
+  DefineBackupRef* ref = (DefineBackupRef*)signal->getDataPtrSend();
+  int err_code = 0;
+  char * extra_msg = NULL;
+
+  switch(ref->errorCode){
+    case DefineBackupRef::Undefined:
+    case DefineBackupRef::FailedToSetupFsBuffers:
+    case DefineBackupRef::FailedToAllocateBuffers: 
+    case DefineBackupRef::FailedToAllocateTables: 
+    case DefineBackupRef::FailedAllocateTableMem: 
+    case DefineBackupRef::FailedToAllocateFileRecord:
+    case DefineBackupRef::FailedToAllocateAttributeRecord:
+    case DefineBackupRef::FailedInsertFileHeader: 
+    case DefineBackupRef::FailedInsertTableList: 
+      jam();
+      err_code = NDBD_EXIT_INVALID_CONFIG;
+      extra_msg = "Probably Backup parameters configuration error, Please consult the manual";
+      progError(__LINE__, err_code, extra_msg);
+  }
+
   sendsttorryLab(signal);
 }