List:Commits« Previous MessageNext Message »
From:Aditya A Date:March 7 2013 9:24am
Subject:bzr push into mysql-5.5 branch (aditya.a:4249 to 4250) Bug#16069598
View as plain text  
 4250 Aditya A	2013-03-07
      BUG#16069598 - SERVER CRASH BY NULL POINTER DEREFERENCING IN 
                     MEM_HEAP_CREATE_BLOCK() 
      
      PROBLEM
      -------
      
      If we give start mysqld with the option --innodb_log_buffer_size=50GB
      ,then  mem_area_alloc() function fails to allocate memory and returns
      NULL.In debug version we assert at this point,but there is no check in
      release version and we get a segmentation fault.
      
      FIX
      ---
      Added a log message saying that we are unable to allocate memory.
      After this message we assert.
      
      [Approved by Kevin http://rb.no.oracle.com/rb/r/2065 ]

    modified:
      storage/innobase/mem/mem0mem.c
 4249 Tor Didriksen	2013-03-01
      Bug#11765489 CMAKE BUILD ON MAC OS X DOES NOT DETERMINE CPU TYPE
      
      Don't use CMAKE_OSX_ARCHITECTURES to determine DEFAULT_MACHINE
      if it is not defined.
      
      If we're 64bit, then use "x86_64" rather than "x86"

    modified:
      cmake/package_name.cmake
=== modified file 'storage/innobase/mem/mem0mem.c'
--- a/storage/innobase/mem/mem0mem.c	revid:tor.didriksen@stripped
+++ b/storage/innobase/mem/mem0mem.c	revid:aditya.a@stripped
@@ -353,7 +353,13 @@ mem_heap_create_block(
 		block = (mem_block_t*) buf_block->frame;
 	}
 
-	ut_ad(block);
+	if(!block) {
+		ut_print_timestamp(stderr);
+		fprintf(stderr,
+			" InnoDB: Unable to allocate memory of size %lu.\n",
+			len);
+		ut_error;
+	}
 	block->buf_block = buf_block;
 	block->free_block = NULL;
 #else /* !UNIV_HOTBACKUP */

No bundle (reason: useless for push emails).
Thread
bzr push into mysql-5.5 branch (aditya.a:4249 to 4250) Bug#16069598Aditya A3 Apr