List:Commits« Previous MessageNext Message »
From:Pedro Gomes Date:February 8 2013 12:24pm
Subject:bzr push into mysql-5.6 branch (pedro.gomes:4742 to 4743) Bug#14677824
View as plain text  
 4743 Pedro Gomes	2013-02-08
      BUG#14677824 CLOSE_ACTIVE_MI FREED MEMORY THAT CONTAINS ACTIVE CRITICAL SECTIONS
      
      When being destroyed, Relay_log_info objects had some critical
      sections not being properly deleted before freeing the memory.
      The problem was in the stage_manager, owned by the associated
      relay_log object that was never properly cleaned.
      
      The stage_manager's method deinit is now called on the
      mysql_bin_log cleanup method, assuring a proper destruction of
      Relay_log_info objects.

    modified:
      sql/binlog.cc
 4742 Venkatesh Duggirala	2013-02-08 [merge]
      BUG#16247322-MTR NOT RUNNING SYS_VARS TEST SUITE FOR 5.1
      Null merge from mysql-5.5

=== modified file 'sql/binlog.cc'
--- a/sql/binlog.cc	revid:venkatesh.duggirala@stripped
+++ b/sql/binlog.cc	revid:pedro.gomes@stripped
@@ -2314,6 +2314,7 @@ void MYSQL_BIN_LOG::cleanup()
     mysql_cond_destroy(&update_cond);
     my_atomic_rwlock_destroy(&m_prep_xids_lock);
     mysql_cond_destroy(&m_prep_xids_cond);
+    stage_manager.deinit();
   }
   DBUG_VOID_RETURN;
 }

No bundle (reason: useless for push emails).
Thread
bzr push into mysql-5.6 branch (pedro.gomes:4742 to 4743) Bug#14677824Pedro Gomes3 Apr