List:Commits« Previous MessageNext Message »
From:Nirbhay Choubey Date:January 4 2013 11:17am
Subject:bzr push into mysql-5.6 branch (nirbhay.choubey:4841 to 4842) Bug#16066243
View as plain text  
 4842 Nirbhay Choubey	2013-01-04 [merge]
      Merge of patch for bug#16066243 from mysql-5.5.

    modified:
      mysys/my_lib.c
 4841 Tor Didriksen	2013-01-04
      Bug#16057793 MAKE TEST FAILS
      
      Some of the tests for Field_timef were non-deterministic:
      it worked only for certain time zones.
      Fixed by ignoring the "yy-mm-dd" part of the datetime string.
     @ unittest/gunit/CMakeLists.txt
        Gmock uses NULL dereferences, add -Wno-null-dereference
        for compilers which support it.
     @ unittest/gunit/test_utils.cc
        Initialize THD::start_time.

    modified:
      unittest/gunit/CMakeLists.txt
      unittest/gunit/field-t.cc
      unittest/gunit/test_utils.cc
=== modified file 'mysys/my_lib.c'
--- a/mysys/my_lib.c	2012-03-08 09:44:21 +0000
+++ b/mysys/my_lib.c	2013-01-04 11:14:14 +0000
@@ -96,7 +96,7 @@ MY_DIR	*my_dir(const char *path, myf MyF
   MEM_ROOT      *names_storage;
   DIR		*dirp;
   struct dirent *dp;
-  char		tmp_path[FN_REFLEN+1],*tmp_file;
+  char		tmp_path[FN_REFLEN + 2], *tmp_file;
   char	dirent_tmp[sizeof(struct dirent)+_POSIX_PATH_MAX+1];
 
   DBUG_ENTER("my_dir");
@@ -201,10 +201,11 @@ char * directory_file_name (char * dst,
 {
   /* Process as Unix format: just remove test the final slash. */
   char *end;
+  DBUG_ASSERT(strlen(src) < (FN_REFLEN + 1));
 
   if (src[0] == 0)
     src= (char*) ".";				/* Use empty as current */
-  end=strmov(dst, src);
+  end= strnmov(dst, src, FN_REFLEN + 1);
   if (end[-1] != FN_LIBCHAR)
   {
     end[0]=FN_LIBCHAR;				/* Add last '/' */

No bundle (reason: useless for push emails).
Thread
bzr push into mysql-5.6 branch (nirbhay.choubey:4841 to 4842) Bug#16066243Nirbhay Choubey28 Jan