From: Vladislav Vaintroub Date: November 21 2012 9:48pm Subject: RE: bzr push into mysql-trunk branch (tor.didriksen:4857 to 4858) List-Archive: http://lists.mysql.com/commits/145373 Message-Id: <007f01cdc832$03e0b330$0ba21990$@montyprogram.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > -----Original Message----- > From: Tor Didriksen [mailto:tor.didriksen@stripped] > Sent: Mittwoch, 21. November 2012 15:52 > To: Vladislav Vaintroub > Cc: commits@stripped > Subject: Re: bzr push into mysql-trunk branch (tor.didriksen:4857 to 4858) > > On 2012-11-17 10:35, Vladislav Vaintroub wrote: > >> Hello Wlad > >> > > >> > We patched YaSSL for a memory leak (a day or two earlier I think). > >> > That patch needed pthread_once(), and we got linking problems on > some > >> > platforms (freebsd and/or osx) > > Ok, but what is different in INCLUDE compared to FIND_PACKAGE? Both > should > > define CMAKE_THREAD_LIBS_INIT , or not? > > > >> > -- didrik > >> > > > hello again. > > you are right, of course :-) > > I didn't realize that > INCLUDE(Findxxx) > is the same as > FIND_PACKAGE(xxx) > Grepping through the cmake code, we also have: > cmake/zlib.cmake: INCLUDE(FindZLIB) Hi Tor, Yeah, confusing zlib thing this is my fault. It was one of my first lines of "code" in CMake, when I was still learning it, and did not know better. Cheers, Wlad