List:Commits« Previous MessageNext Message »
From:Tor Didriksen Date:November 16 2012 2:32pm
Subject:Re: bzr push into mysql-trunk branch (tor.didriksen:4857 to 4858)
View as plain text  
On 2012-11-16 14:43, Vladislav Vaintroub wrote:
>
>> -----Original Message-----
>> From: Tor Didriksen [mailto:tor.didriksen@stripped]
>> Sent: Dienstag, 30. Oktober 2012 14:54
>> To: commits@stripped
>> Subject: bzr push into mysql-trunk branch (tor.didriksen:4857 to 4858)
>>
> Hi Tor,
>> === modified file 'configure.cmake'
>> --- a/configure.cmake	2012-05-15 09:39:47 +0000
>> +++ b/configure.cmake	2012-10-30 13:49:44 +0000
>> @@ -325,13 +325,14 @@ ENDIF()
>>   # Figure out threading library
>>   #
>>   FIND_PACKAGE (Threads)
>> +# Defines CMAKE_USE_PTHREADS_INIT and CMAKE_THREAD_LIBS_INIT.
>> +INCLUDE(FindThreads)
> Can you explain , what does this fix ?
> I tend to  agree with comment, but INCLUDE looks strange. FIND_PACKAGE would
> be typically the way to go, to me.
>
> Thanks,
> Wlad
>
Hello Wlad

We patched YaSSL for a memory leak (a day or two earlier I think).
That patch needed pthread_once(), and we got linking problems on some 
platforms (freebsd and/or osx)

-- didrik


Thread
bzr push into mysql-trunk branch (tor.didriksen:4857 to 4858) Tor Didriksen16 Nov
  • RE: bzr push into mysql-trunk branch (tor.didriksen:4857 to 4858) Vladislav Vaintroub16 Nov
    • Re: bzr push into mysql-trunk branch (tor.didriksen:4857 to 4858)Tor Didriksen19 Nov
Re: bzr push into mysql-trunk branch (tor.didriksen:4857 to 4858)Tor Didriksen21 Nov
  • RE: bzr push into mysql-trunk branch (tor.didriksen:4857 to 4858)Vladislav Vaintroub22 Nov