List:Commits« Previous MessageNext Message »
From:Tor Didriksen Date:November 16 2012 12:42pm
Subject:bzr push into mysql-5.6 branch (tor.didriksen:4611 to 4612) Bug#14828028
View as plain text  
 4612 Tor Didriksen	2012-11-16
      BUG#14828028 - TRANSACTION SKIPPED USING GTIDS CAUSES NEXT RECONNECTION BY IO THREAD TO FAIL
      
      Post-push fix: memcpy(ptr, "", < n greater than 1 >) is undefined behaviour,
      and crashes when compiled with 'clang -faddress-sanitizer'

    modified:
      sql/rpl_slave.cc
 4611 Mattias Jonsson	2012-11-16 [merge]
      merge of bug14845133 from 5.5 to 5.6

=== modified file 'sql/rpl_slave.cc'
--- a/sql/rpl_slave.cc	2012-11-09 11:01:37 +0000
+++ b/sql/rpl_slave.cc	2012-11-16 12:15:45 +0000
@@ -2992,7 +2992,7 @@ static int request_dump(THD *thd, MYSQL*
     ptr_buffer+= ::BINLOG_SERVER_ID_INFO_SIZE;
     int4store(ptr_buffer, BINLOG_NAME_INFO_SIZE);
     ptr_buffer+= ::BINLOG_NAME_SIZE_INFO_SIZE;
-    memcpy(ptr_buffer, "", BINLOG_NAME_INFO_SIZE);
+    memset(ptr_buffer, 0, BINLOG_NAME_INFO_SIZE);
     ptr_buffer+= BINLOG_NAME_INFO_SIZE;
     int8store(ptr_buffer, 4);
     ptr_buffer+= ::BINLOG_POS_INFO_SIZE;

No bundle (reason: useless for push emails).
Thread
bzr push into mysql-5.6 branch (tor.didriksen:4611 to 4612) Bug#14828028Tor Didriksen16 Nov