bk commit into 5.0 tree (stewart:1.2275) BUG#22310

[Stewart Smith]

Below is the list of changes that have just been committed into a local
5.0 repository of stewart. When stewart does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-10-27 18:08:08+10:00, stewart@willster.(none) +2 -0
  BUG#22310 dead/deceptive code in FileLogHandler::writeFooter() and File_class::flush
  
  make the File_class::flush() method actually flush the stdio buffers.

  ndb/src/common/logger/FileLogHandler.cpp@stripped, 2006-10-27 18:08:03+10:00, stewart@willster.(none) +0 -2
    remove misleading comment

  ndb/src/common/util/File.cpp@stripped, 2006-10-27 18:08:04+10:00, stewart@willster.(none) +1 -5
    actually flush the stdio buffers.
    
    remove unneeded // private comment

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	stewart
# Host:	willster.(none)
# Root:	/home/stewart/Documents/MySQL/5.0/ndb-mgm-work

--- 1.12/ndb/src/common/logger/FileLogHandler.cpp	2006-10-27 18:08:13 +10:00
+++ 1.13/ndb/src/common/logger/FileLogHandler.cpp	2006-10-27 18:08:13 +10:00
@@ -125,8 +125,6 @@
   }
   callCount++;
 
-  // Needed on Cello since writes to the flash disk does not happen until 
-  // we flush and fsync.
   m_pLogFile->flush();
 }
 

--- 1.12/ndb/src/common/util/File.cpp	2006-10-27 18:08:13 +10:00
+++ 1.13/ndb/src/common/util/File.cpp	2006-10-27 18:08:13 +10:00
@@ -188,10 +188,6 @@
   ::fflush(m_file);
   return ::fsync(::fileno(m_file));
 #else
-  return 0;
+  return ::fflush(m_file);;
 #endif
 }
-
-//
-// PRIVATE
-//