List:Commits« Previous MessageNext Message »
From:Ole John Aske Date:August 16 2012 12:17pm
Subject:bzr push into mysql-5.5-cluster-7.2-threads branch (ole.john.aske:3975 to
3976)
View as plain text  
 3976 Ole John Aske	2012-08-16
      Initial push to new branch: mysql-5.5-cluster-7.2-threads
      
      Intention of this push / branch is to have a 'sandbox' for testing configs with 
      increased number of threads in ndbmtd.
      
      In our main branches mots of the tests are run wo/ specifing any 'thread' related
      stuff in the config. This results in the tests being run with a only a 
      single TC-, LDM- and receiver-thread - Not really much MT'ing at all.
      
      This initial setup increase that to use 2*LDM's as a smoke test for MT related bugs.
      Our intention is to also increase the number of the other MT'ed blocks when
      we have ironed out any problems found by having 2 LDM's.

    modified:
      .bzr-mysql/default.conf
      mysql-test/include/default_ndbd.cnf
 3975 Ole John Aske	2012-08-14
      Fix for Bug#14489398 CLUSTER BACKUP FAILS WHEN USING NDBMTD AND CONFIGURED MULTIPLE LQHS
      
      Fix regression introduced by push:
      
      3923 Ole John Aske	2012-05-23
            This is the improved 'save_mem.patch' from Mikael R. patch set
      
      That push tried to save memory used for interthread communication buffers
      by not allocated buffers between those threads which was assumed to not communicate.
      LDM <-> LDM communication was one of the places where such buffers where removed.
      
      However, the BACKUP-block is part of the LDM thread, and during backup the 
      first BACKUP instance in LDM thread#1 will act as client/coordinator. Thus
      it *will* communicate with other LDM threads!
      
      This fix introduce special handling of LDM thread#1, and 'opens up' communication
      between that thread and other LDM threads. Instead of writing a completely new
      testcase to cover this fix, I have introduced 'ndb_restore_misc.cnf' which overrides
      'MaxNoOfExecutionThreads=4' - Such that at least one of the existing backup-restore
      tests are run with multiple LDM threads.
      
      If the BACKUP is later made full multithreaded, the changes to mt.cpp in
      this patch should be reverted.

    added:
      mysql-test/suite/ndb/t/ndb_restore_misc.cnf
    modified:
      storage/ndb/src/kernel/vm/mt.cpp
=== modified file '.bzr-mysql/default.conf'
--- a/.bzr-mysql/default.conf	2012-07-05 10:39:45 +0000
+++ b/.bzr-mysql/default.conf	2012-08-16 12:16:32 +0000
@@ -1,4 +1,4 @@
 [MYSQL]
 post_commit_to = "commits@stripped"
 post_push_to = "commits@stripped"
-tree_name = "mysql-5.5-cluster-7.2"
+tree_name = "mysql-5.5-cluster-7.2-threads"

=== modified file 'mysql-test/include/default_ndbd.cnf'
--- a/mysql-test/include/default_ndbd.cnf	2011-11-03 17:22:01 +0000
+++ b/mysql-test/include/default_ndbd.cnf	2012-08-16 12:16:32 +0000
@@ -31,3 +31,11 @@ HeartbeatIntervalDbApi=        30000
 
 #TransactionDeadlockDetectionTimeout= 7500
 DiskIOThreadPool=1
+
+# Configure a very modest level if MT'ing as default:
+# - Only 2 LDM's, and a single TC and RECV thread
+# - No seperate send threads
+#
+# (Option is ignored for non-MT'ed NDB)
+#
+ThreadConfig=main={count=1},tc={count=1},ldm={count=2},io={count=1},rep={count=1},recv={count=1},send={count=0}

No bundle (reason: useless for push emails).
Thread
bzr push into mysql-5.5-cluster-7.2-threads branch (ole.john.aske:3975 to3976) Ole John Aske16 Aug