4089 Vasil Dimov 2012-07-31
Use rw_lock_own() only if UNIV_SYNC_DEBUG is defined since its not
available otherwise.
Reported by: Michael Izioumtchenko
modified:
storage/innobase/dict/dict0stats.cc
4088 Hemant Kumar 2012-07-31
Includes following non-functional changes in collection-
-Removed redundant test runs from daily (like normal-debug,
embedded-debug,ps-debug)
-Updated memcached tests to run with "--debug-server" option on daily.
-Added memcached tests to run with and without "--debug-server" option on weekly.
modified:
mysql-test/collections/default.daily
mysql-test/collections/default.weekly
=== modified file 'storage/innobase/dict/dict0stats.cc'
--- a/storage/innobase/dict/dict0stats.cc revid:hemant.hk.kumar@stripped
+++ b/storage/innobase/dict/dict0stats.cc revid:vasil.dimov@stripped
@@ -279,7 +279,9 @@ dict_stats_exec_sql(
trx_t* trx;
dberr_t err;
+#ifdef UNIV_SYNC_DEBUG
ut_ad(rw_lock_own(&dict_operation_lock, RW_LOCK_EX));
+#endif /* UNIV_SYNC_DEBUG */
ut_ad(mutex_own(&dict_sys->mutex));
if (!dict_stats_persistent_storage_check(true)) {
@@ -2206,7 +2208,9 @@ dict_stats_save_index_stat(
pars_info_t* pinfo;
dberr_t ret;
+#ifdef UNIV_SYNC_DEBUG
ut_ad(rw_lock_own(&dict_operation_lock, RW_LOCK_EX));
+#endif /* UNIV_SYNC_DEBUG */
ut_ad(mutex_own(&dict_sys->mutex));
pinfo = pars_info_create();
@@ -3331,7 +3335,9 @@ dict_stats_delete_from_table_stats(
pars_info_t* pinfo;
dberr_t ret;
+#ifdef UNIV_SYNC_DEBUG
ut_ad(rw_lock_own(&dict_operation_lock, RW_LOCK_EX));
+#endif /* UNIV_STAT */
ut_ad(mutex_own(&dict_sys->mutex));
pinfo = pars_info_create();
@@ -3369,7 +3375,9 @@ dict_stats_delete_from_index_stats(
pars_info_t* pinfo;
dberr_t ret;
+#ifdef UNIV_SYNC_DEBUG
ut_ad(rw_lock_own(&dict_operation_lock, RW_LOCK_EX));
+#endif /* UNIV_STAT */
ut_ad(mutex_own(&dict_sys->mutex));
pinfo = pars_info_create();
@@ -3409,7 +3417,9 @@ dict_stats_drop_table(
const char* table_name_strip; /* without leading db name */
dberr_t ret;
+#ifdef UNIV_SYNC_DEBUG
ut_ad(rw_lock_own(&dict_operation_lock, RW_LOCK_EX));
+#endif /* UNIV_STAT */
ut_ad(mutex_own(&dict_sys->mutex));
/* skip tables that do not contain a database name
@@ -3492,7 +3502,9 @@ dict_stats_rename_in_table_stats(
pars_info_t* pinfo;
dberr_t ret;
+#ifdef UNIV_SYNC_DEBUG
ut_ad(rw_lock_own(&dict_operation_lock, RW_LOCK_EX));
+#endif /* UNIV_STAT */
ut_ad(mutex_own(&dict_sys->mutex));
pinfo = pars_info_create();
@@ -3538,7 +3550,9 @@ dict_stats_rename_in_index_stats(
pars_info_t* pinfo;
dberr_t ret;
+#ifdef UNIV_SYNC_DEBUG
ut_ad(rw_lock_own(&dict_operation_lock, RW_LOCK_EX));
+#endif /* UNIV_STAT */
ut_ad(mutex_own(&dict_sys->mutex));
pinfo = pars_info_create();
@@ -3585,7 +3599,9 @@ dict_stats_rename_table(
const char* new_table_name; /* without leading db name */
dberr_t ret;
+#ifdef UNIV_SYNC_DEBUG
ut_ad(!rw_lock_own(&dict_operation_lock, RW_LOCK_EX));
+#endif /* UNIV_STAT */
ut_ad(!mutex_own(&dict_sys->mutex));
/* skip innodb_table_stats and innodb_index_stats themselves */
No bundle (reason: useless for push emails).
| Thread |
|---|
| • bzr push into mysql-5.6 branch (vasil.dimov:4088 to 4089) | vasil.dimov | 5 Aug |