From: Jon Olav Hauglid Date: June 29 2012 12:22pm Subject: bzr push into mysql-5.5 branch (jon.hauglid:3877 to 3878) Bug#14238406 List-Archive: http://lists.mysql.com/commits/144359 X-Bug: 14238406 Message-Id: <20120629122210.26175.69332.3878@atum08.no.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit 3878 Jon Olav Hauglid 2012-06-29 [merge] Bug#14238406 NEW COMPILATION WARNINGS WITH GCC 4.7 (-WERROR=NARROWING) Manual merge from mysql-5.1 to mysql-5.5 modified: client/mysqlbinlog.cc client/mysqltest.cc include/my_getopt.h plugin/semisync/semisync.cc plugin/semisync/semisync.h plugin/semisync/semisync_master_plugin.cc plugin/semisync/semisync_slave_plugin.cc sql/log.h sql/sql_plugin.cc sql/sql_plugin.h sql/sql_profile.cc storage/innobase/handler/ha_innodb.cc 3877 Gleb Shchepa 2012-06-29 [merge] manual merge (WL6219) @ sql/sql_yacc.yy manual merge (backport of WL6219) modified: mysql-test/r/ctype_binary.result mysql-test/r/ctype_cp1251.result mysql-test/r/ctype_latin1.result mysql-test/r/ctype_ucs.result mysql-test/r/ctype_utf8.result mysql-test/r/func_group.result mysql-test/r/type_blob.result mysql-test/r/type_year.result mysql-test/suite/engines/iuds/r/delete_year.result mysql-test/suite/engines/iuds/r/insert_year.result mysql-test/suite/engines/iuds/r/update_year.result mysql-test/suite/funcs_1/r/innodb_views.result mysql-test/suite/funcs_1/r/is_columns_innodb.result mysql-test/suite/funcs_1/r/is_columns_memory.result mysql-test/suite/funcs_1/r/is_columns_myisam.result mysql-test/suite/funcs_1/r/is_columns_myisam_embedded.result mysql-test/suite/funcs_1/r/memory_views.result mysql-test/suite/funcs_1/r/myisam_views-big.result mysql-test/suite/funcs_1/r/storedproc.result mysql-test/suite/innodb/r/innodb_bug52745.result mysql-test/t/type_year.test sql/field.cc sql/sql_yacc.yy === modified file 'client/mysqlbinlog.cc' --- a/client/mysqlbinlog.cc 2012-05-29 06:51:17 +0000 +++ b/client/mysqlbinlog.cc 2012-06-29 11:36:01 +0000 @@ -1,5 +1,5 @@ /* - Copyright (c) 2000, 2011, Oracle and/or its affiliates. All rights reserved. + Copyright (c) 2000, 2012, Oracle and/or its affiliates. All rights reserved. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -1162,7 +1162,7 @@ static struct my_option my_long_options[ "Stop reading the binlog at position N. Applies to the last binlog " "passed on the command line.", &stop_position, &stop_position, 0, GET_ULL, - REQUIRED_ARG, (ulonglong)(~(my_off_t)0), BIN_LOG_HEADER_SIZE, + REQUIRED_ARG, (longlong)(~(my_off_t)0), BIN_LOG_HEADER_SIZE, (ulonglong)(~(my_off_t)0), 0, 0, 0}, {"to-last-log", 't', "Requires -R. Will not stop at the end of the \ requested binlog but rather continue printing until the end of the last \ === modified file 'client/mysqltest.cc' --- a/client/mysqltest.cc 2011-11-08 14:55:25 +0000 +++ b/client/mysqltest.cc 2012-06-29 11:36:01 +0000 @@ -1,4 +1,4 @@ -/* Copyright (c) 2000, 2011, Oracle and/or its affiliates. All rights reserved. +/* Copyright (c) 2000, 2012, Oracle and/or its affiliates. All rights reserved. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -4823,7 +4823,7 @@ typedef struct static st_error global_error_names[] = { - { "", -1, "" }, + { "", -1U, "" }, #include { 0, 0, 0 } }; === modified file 'include/my_getopt.h' --- a/include/my_getopt.h 2011-07-03 23:48:19 +0000 +++ b/include/my_getopt.h 2012-06-29 11:36:01 +0000 @@ -1,5 +1,5 @@ /* - Copyright (c) 2002, 2011, Oracle and/or its affiliates. All rights reserved. + Copyright (c) 2002, 2012, Oracle and/or its affiliates. All rights reserved. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -79,7 +79,7 @@ struct my_option enum get_opt_arg_type arg_type; /**< e.g. REQUIRED_ARG or OPT_ARG */ longlong def_value; /**< Default value */ longlong min_value; /**< Min allowed value (for numbers) */ - longlong max_value; /**< Max allowed value (for numbers) */ + ulonglong max_value; /**< Max allowed value (for numbers) */ longlong sub_size; /**< Unused */ long block_size; /**< Value should be a mult. of this (for numbers) */ void *app_type; /**< To be used by an application */ === modified file 'plugin/semisync/semisync.cc' --- a/plugin/semisync/semisync.cc 2009-09-26 04:49:49 +0000 +++ b/plugin/semisync/semisync.cc 2012-06-29 11:36:01 +0000 @@ -26,5 +26,5 @@ const unsigned long Trace::kTraceDetail const unsigned long Trace::kTraceNetWait = 0x0020; const unsigned long Trace::kTraceFunction = 0x0040; -const char ReplSemiSyncBase::kSyncHeader[2] = +const unsigned char ReplSemiSyncBase::kSyncHeader[2] = {ReplSemiSyncBase::kPacketMagicNum, 0}; === modified file 'plugin/semisync/semisync.h' --- a/plugin/semisync/semisync.h 2010-03-31 14:05:33 +0000 +++ b/plugin/semisync/semisync.h 2012-06-29 11:36:01 +0000 @@ -71,7 +71,7 @@ public: class ReplSemiSyncBase :public Trace { public: - static const char kSyncHeader[2]; /* three byte packet header */ + static const unsigned char kSyncHeader[2]; /* three byte packet header */ /* Constants in network packet header. */ static const unsigned char kPacketMagicNum; === modified file 'plugin/semisync/semisync_master_plugin.cc' --- a/plugin/semisync/semisync_master_plugin.cc 2011-08-15 18:12:11 +0000 +++ b/plugin/semisync/semisync_master_plugin.cc 2012-06-29 11:36:01 +0000 @@ -180,7 +180,7 @@ static MYSQL_SYSVAR_ULONG(timeout, rpl_s "The timeout value (in ms) for semi-synchronous replication in the master", NULL, // check fix_rpl_semi_sync_master_timeout, // update - 10000, 0, ~0L, 1); + 10000, 0, ~0UL, 1); static MYSQL_SYSVAR_BOOL(wait_no_slave, rpl_semi_sync_master_wait_no_slave, PLUGIN_VAR_OPCMDARG, @@ -194,7 +194,7 @@ static MYSQL_SYSVAR_ULONG(trace_level, r "The tracing level for semi-sync replication.", NULL, // check &fix_rpl_semi_sync_master_trace_level, // update - 32, 0, ~0L, 1); + 32, 0, ~0UL, 1); static SYS_VAR* semi_sync_master_system_vars[]= { MYSQL_SYSVAR(enabled), === modified file 'plugin/semisync/semisync_slave_plugin.cc' --- a/plugin/semisync/semisync_slave_plugin.cc 2011-08-15 18:12:11 +0000 +++ b/plugin/semisync/semisync_slave_plugin.cc 2012-06-29 11:36:01 +0000 @@ -161,7 +161,7 @@ static MYSQL_SYSVAR_ULONG(trace_level, r "The tracing level for semi-sync replication.", NULL, // check &fix_rpl_semi_sync_trace_level, // update - 32, 0, ~0L, 1); + 32, 0, ~0UL, 1); static SYS_VAR* semi_sync_slave_system_vars[]= { MYSQL_SYSVAR(enabled), === modified file 'sql/log.h' --- a/sql/log.h 2012-04-20 22:35:53 +0000 +++ b/sql/log.h 2012-06-29 11:36:01 +0000 @@ -1,4 +1,4 @@ -/* Copyright (c) 2005, 2011, Oracle and/or its affiliates. All rights reserved. +/* Copyright (c) 2005, 2012, Oracle and/or its affiliates. All rights reserved. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -353,8 +353,8 @@ class MYSQL_BIN_LOG: public TC_LOG, priv int new_file_impl(bool need_lock); public: - MYSQL_LOG::generate_name; - MYSQL_LOG::is_open; + using MYSQL_LOG::generate_name; + using MYSQL_LOG::is_open; /* This is relay log */ bool is_relay_log; === modified file 'sql/sql_plugin.cc' --- a/sql/sql_plugin.cc 2012-02-16 09:48:16 +0000 +++ b/sql/sql_plugin.cc 2012-06-29 11:36:01 +0000 @@ -714,7 +714,7 @@ bool plugin_is_ready(const LEX_STRING *n } -SHOW_COMP_OPTION plugin_status(const char *name, int len, size_t type) +SHOW_COMP_OPTION plugin_status(const char *name, size_t len, int type) { LEX_STRING plugin_name= { (char *) name, len }; return plugin_status(&plugin_name, type); === modified file 'sql/sql_plugin.h' --- a/sql/sql_plugin.h 2011-06-30 15:46:53 +0000 +++ b/sql/sql_plugin.h 2012-06-29 11:36:01 +0000 @@ -1,4 +1,4 @@ -/* Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved. +/* Copyright (c) 2005, 2012, Oracle and/or its affiliates. All rights reserved. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -154,7 +154,7 @@ extern bool mysql_uninstall_plugin(THD * extern bool plugin_register_builtin(struct st_mysql_plugin *plugin); extern void plugin_thdvar_init(THD *thd); extern void plugin_thdvar_cleanup(THD *thd); -extern SHOW_COMP_OPTION plugin_status(const char *name, int len, size_t type); +extern SHOW_COMP_OPTION plugin_status(const char *name, size_t len, int type); extern bool check_valid_path(const char *path, size_t length); typedef my_bool (plugin_foreach_func)(THD *thd, === modified file 'sql/sql_profile.cc' --- a/sql/sql_profile.cc 2012-02-16 09:48:16 +0000 +++ b/sql/sql_profile.cc 2012-06-29 11:36:01 +0000 @@ -1,4 +1,4 @@ -/* Copyright (c) 2007, 2011, Oracle and/or its affiliates. All rights reserved. +/* Copyright (c) 2007, 2012, Oracle and/or its affiliates. All rights reserved. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -83,8 +83,8 @@ ST_FIELD_INFO query_profile_statistics_i int make_profile_table_for_show(THD *thd, ST_SCHEMA_TABLE *schema_table) { - int profile_options = thd->lex->profile_options; - int fields_include_condition_truth_values[]= { + uint profile_options = thd->lex->profile_options; + uint fields_include_condition_truth_values[]= { FALSE, /* Query_id */ FALSE, /* Seq */ TRUE, /* Status */ === modified file 'storage/innobase/handler/ha_innodb.cc' --- a/storage/innobase/handler/ha_innodb.cc 2012-06-01 07:31:24 +0000 +++ b/storage/innobase/handler/ha_innodb.cc 2012-06-29 11:36:01 +0000 @@ -11337,7 +11337,7 @@ static MYSQL_SYSVAR_BOOL(doublewrite, in static MYSQL_SYSVAR_ULONG(io_capacity, srv_io_capacity, PLUGIN_VAR_RQCMDARG, "Number of IOPs the server can do. Tunes the background IO rate", - NULL, NULL, 200, 100, ~0L, 0); + NULL, NULL, 200, 100, ~0UL, 0); static MYSQL_SYSVAR_ULONG(purge_batch_size, srv_purge_batch_size, PLUGIN_VAR_OPCMDARG, @@ -11454,7 +11454,7 @@ static MYSQL_SYSVAR_BOOL(adaptive_flushi static MYSQL_SYSVAR_ULONG(max_purge_lag, srv_max_purge_lag, PLUGIN_VAR_RQCMDARG, "Desired maximum length of the purge queue (0 = no limit)", - NULL, NULL, 0, 0, ~0L, 0); + NULL, NULL, 0, 0, ~0UL, 0); static MYSQL_SYSVAR_BOOL(rollback_on_timeout, innobase_rollback_on_timeout, PLUGIN_VAR_OPCMDARG | PLUGIN_VAR_READONLY, @@ -11516,7 +11516,7 @@ static MYSQL_SYSVAR_ULONG(commit_concurr static MYSQL_SYSVAR_ULONG(concurrency_tickets, srv_n_free_tickets_to_enter, PLUGIN_VAR_RQCMDARG, "Number of times a thread is allowed to enter InnoDB within the same SQL query after it has once got the ticket", - NULL, NULL, 500L, 1L, ~0L, 0); + NULL, NULL, 500L, 1L, ~0UL, 0); static MYSQL_SYSVAR_LONG(file_io_threads, innobase_file_io_threads, PLUGIN_VAR_RQCMDARG | PLUGIN_VAR_READONLY | PLUGIN_VAR_NOSYSVAR, @@ -11578,12 +11578,12 @@ static MYSQL_SYSVAR_LONG(open_files, inn static MYSQL_SYSVAR_ULONG(sync_spin_loops, srv_n_spin_wait_rounds, PLUGIN_VAR_RQCMDARG, "Count of spin-loop rounds in InnoDB mutexes (30 by default)", - NULL, NULL, 30L, 0L, ~0L, 0); + NULL, NULL, 30L, 0L, ~0UL, 0); static MYSQL_SYSVAR_ULONG(spin_wait_delay, srv_spin_wait_delay, PLUGIN_VAR_OPCMDARG, "Maximum delay between polling for a spin lock (6 by default)", - NULL, NULL, 6L, 0L, ~0L, 0); + NULL, NULL, 6L, 0L, ~0UL, 0); static MYSQL_SYSVAR_ULONG(thread_concurrency, srv_thread_concurrency, PLUGIN_VAR_RQCMDARG, @@ -11593,7 +11593,7 @@ static MYSQL_SYSVAR_ULONG(thread_concurr static MYSQL_SYSVAR_ULONG(thread_sleep_delay, srv_thread_sleep_delay, PLUGIN_VAR_RQCMDARG, "Time of innodb thread sleeping before joining InnoDB queue (usec). Value 0 disable a sleep", - NULL, NULL, 10000L, 0L, ~0L, 0); + NULL, NULL, 10000L, 0L, ~0UL, 0); static MYSQL_SYSVAR_STR(data_file_path, innobase_data_file_path, PLUGIN_VAR_RQCMDARG | PLUGIN_VAR_READONLY, No bundle (reason: useless for push emails).