bk commit into 5.1 tree (stewart:1.2310) BUG#23655

[Stewart Smith]

Below is the list of changes that have just been committed into a local
5.1 repository of stewart. When stewart does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-10-26 21:37:23+10:00, stewart@willster.(none) +1 -0
  BUG#23655 deadlock in query cache ndb_cache tests with --debug
  
  Deadlock when running ndb_cache tests with --debug. Query cache locks on trying
  to acquire lock.

  sql/sql_cache.cc@stripped, 2006-10-26 21:37:20+10:00, stewart@willster.(none) +2 -3
    in query_cache_end_of_result, unlock in reverse order of locking.
    
    also make it possible to run with --debug without hanging.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	stewart
# Host:	willster.(none)
# Root:	/home/stewart/Documents/MySQL/5.1/pending

--- 1.98/sql/sql_cache.cc	2006-10-26 21:37:30 +10:00
+++ 1.99/sql/sql_cache.cc	2006-10-26 21:37:30 +10:00
@@ -747,11 +747,10 @@
     header->result()->type= Query_cache_block::RESULT;
     header->writer(0);
     thd->net.query_cache_query= 0;
-    DBUG_EXECUTE("check_querycache",query_cache.check_integrity(1););
-
-    STRUCT_UNLOCK(&query_cache.structure_guard_mutex);
 
     BLOCK_UNLOCK_WR(query_block);
+    DBUG_EXECUTE("check_querycache",query_cache.check_integrity(1););
+    STRUCT_UNLOCK(&query_cache.structure_guard_mutex);
   }
   else
   {