List:Commits« Previous MessageNext Message »
From:Roy Lyseng Date:May 22 2012 1:08pm
Subject:bzr push into mysql-trunk branch (roy.lyseng:3909 to 3910) Bug#14048292
View as plain text  
 3910 Roy Lyseng	2012-05-22
      Bug#14048292: Segfault in Item_field::result_type on 2nd execution of prep stmt
      
      Post-review fix.
      
      sql/sql_optimizer.cc
        Comment fix.

    modified:
      sql/sql_optimizer.cc
 3909 Roy Lyseng	2012-05-21
      Bug#14058892: Extra rows returned when variable is used in subquery in
                    ON clause of RIGHT JOIN.
      
      The fix for bug#13980954 simplified the way table bits were assigned
      for the tables involved in a join operation. Unfortunately, it missed
      that RAND_TABLE_BIT had to be set for the last inner table of an outer
      join operation, otherwise non-deterministic functions in the join
      condition would be missed.
      
      This fix adds back this bit.
      
      Notice that there is a proposed refactoring of pushdown_on_conditions()
      that will significantly reduce the size of this function.
      
      mysql-test/t/user_var.test
        Added test case for bug#14058892.
      
      mysql-test/r/user_var.result
        Added test case results for bug#14058892.
      
      sql/sql_optimizer.cc
        In pushdown_on_conditions(), add RAND_TABLE_BIT for last inner table
        of an outer join.

    modified:
      mysql-test/r/user_var.result
      mysql-test/t/user_var.test
      sql/sql_optimizer.cc
=== modified file 'sql/sql_optimizer.cc'
--- a/sql/sql_optimizer.cc	2012-05-21 09:14:15 +0000
+++ b/sql/sql_optimizer.cc	2012-05-22 13:07:27 +0000
@@ -6831,8 +6831,8 @@ bool JOIN::flatten_subqueries()
           Some precaution is needed when dealing with PS/SP:
           fix_prepare_info_in_table_list() sets prep_join_cond, but only for
           tables, not for join nest objects. This is instead populated in
-          simplify_joins(), which is called after this function. The case
-          where *tree is NULL is handled by this procedure.
+          record_join_nest_info(), which is called after this function.
+          The case where *tree is NULL is handled by this procedure.
         */
       }
       else

No bundle (reason: useless for push emails).
Thread
bzr push into mysql-trunk branch (roy.lyseng:3909 to 3910) Bug#14048292Roy Lyseng22 May