bzr push into mysql-trunk branch (ashish.y.agarwal:3899 to 3900) WL#2739

[Ashish Agarwal]

 3900 Ashish Agarwal	2012-05-22
      wl#2739: Auditing Password Security
               Test failure on windows and
               valgrind errors.

    modified:
      sql/string_service.cc
      sql/string_service.h
 3899 Ashish Agarwal	2012-05-21
      WL#2739: Auditing Password Security
      ******
      WL#2739: Failing test case in WL branch.
      ******
      WL#2739: Some tests were failing.
               Unable to compile in windows.
               patch to correct the test cases and
               make it compile in windows.
      ******
      wl#2739: Changes in the the test case
               compiling it in windows. 
      ******
      WL#2739: Still some problem exsists with compilation in windows.
               Patch to solve it.
      ******
      wl2739: Auditing Password Security
              Some performance issue.
      ******
      WL#2739: some important changes regarding implementation
               Test fail in windows
      ******
      wl#2739: Build problem in solaris/windows
      ******
      wl2739: Build failure in windows and some additional changes.
      ******
      WL2739: Including password validation on multiple
              character set. 
      ******
      wl2739: Changing the dictionary file
      ******
      WL2739: Test failing on windows.
              Dictionary file is not found in plugin
              directory.
      ******
      wl2739: Test case fails in linux due to dictionary
              file.
      ******
      wl2739: Auditing Password Security
              Impementing review comments.
      ******
      wl2739: Auditing Password Security
              Build failure in windows.
      ******
      wl2739: Auditing Password Security
              Build failure in windows
      ******
      wl2739: Auditing Password Security
              Build failure in windows.
      ******
      WL2739: Auditing Password Security
              Implementing review comments.
      ******
      WL2739: Auditing Password Security
              Implementing review comment
      ******
      wl2739: Auditing Password Security
              Implementing suggestions.
      ******
      wl2739: Auditing Password Security
              Implementing code review.
      ******
      wl2739: Auditing Password Security
              Implementing code review
      ******
      wl2739: Auditing Password Security
              Compilation error in solaris.
      ******
      wl#2739: Auditing Password Security
               Test failure in windows 
      ******
      WL#2739: Auditing Password Security
               Change in the .cnf file

    added:
      include/mysql/plugin_validate_password.h
      include/mysql/service_mysql_string.h
      libservices/mysql_string_service.c
      mysql-test/include/have_validate_password_plugin.inc
      mysql-test/r/validate_password_plugin.result
      mysql-test/t/validate_password_plugin-master.opt
      mysql-test/t/validate_password_plugin.test
      plugin/password_validation/
      plugin/password_validation/CMakeLists.txt
      plugin/password_validation/validate_password.cc
      sql/share/dictionary.txt
      sql/string_service.cc
      sql/string_service.h
    modified:
      include/CMakeLists.txt
      include/mysql/plugin.h
      include/mysql/plugin_audit.h.pp
      include/mysql/plugin_auth.h.pp
      include/mysql/plugin_ftparser.h.pp
      include/mysql/services.h
      include/service_versions.h
      libservices/CMakeLists.txt
      mysql-test/include/plugin.defs
      sql/CMakeLists.txt
      sql/item_create.cc
      sql/item_func.cc
      sql/item_func.h
      sql/item_strfunc.cc
      sql/share/CMakeLists.txt
      sql/share/errmsg-utf8.txt
      sql/sql_acl.cc
      sql/sql_acl.h
      sql/sql_plugin.cc
      sql/sql_plugin_services.h
      sql/sql_yacc.yy
      support-files/CMakeLists.txt
      support-files/my-huge.cnf.sh
      support-files/my-large.cnf.sh
      support-files/my-medium.cnf.sh
      support-files/my-small.cnf.sh
=== modified file 'sql/string_service.cc'
--- a/sql/string_service.cc	2012-05-21 14:22:56 +0000
+++ b/sql/string_service.cc	2012-05-22 13:08:22 +0000
@@ -64,7 +64,7 @@ mysql_string_iterator_handle mysql_strin
 {
   String *str= (String *) string_handle;
   string_iterator *iterator= (string_iterator *) my_malloc(sizeof
-                                                 (string_iterator *), MYF(0));
+                                           (struct st_string_iterator), MYF(0));
   iterator->iterator_str= str;
   iterator->iterator_ptr= str->ptr();
   iterator->ctype= 0;

=== modified file 'sql/string_service.h'
--- a/sql/string_service.h	2012-05-21 14:22:56 +0000
+++ b/sql/string_service.h	2012-05-22 13:08:22 +0000
@@ -21,11 +21,11 @@
 String temp_str;
 
 /* mysql_string_itrerator structure to provide service to plugins */
-struct string_iterator
+typedef struct st_string_iterator
 {
   String *iterator_str;
   const char *iterator_ptr;
   int ctype;
-};
+} string_iterator;
 
 #endif /* MY_STRING_SERVICE_INCLUDED */

No bundle (reason: useless for push emails).