From: sayantan.dutta Date: April 30 2012 7:18am Subject: bzr push into mysql-trunk branch (sayantan.dutta:3751 to 3752) List-Archive: http://lists.mysql.com/commits/143678 Message-Id: <201204300718.q3U7ISi4011697@acsmt357.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit 3752 sayantan.dutta@stripped 2012-04-30 # Turn off check testcases in Valgrind modified: mysql-test/mysql-test-run.pl 3751 Raghav Kapoor 2012-04-30 BUG#11746295 - 25168: "INCORRECT TABLE NAME" INSTEAD OF "IDENTIFIER TOO LONG" IF TABLE NAME > 64 BACKGROUND: When table/database name is more then 64 character, "Incorrect table name" error is thrown. But expected error is "Identifier too long". FIX: This bug has been fixed by reporting ER_TOO_LONG_IDENT error when table/database/function/procedure name etc is greater than 64 characters. Also please note the behaviour changes in check_table_name() and check_and_convert_db_name() functions in table.cc file. Their return type has been changed accordingly to report the appropriate error and now they return enum instead of bool. Other files have also been appropriately modified at relevant places to report the appropriate error in each case. Also a testcase has been written in create.test and corresponding result files have been updated. modified: mysql-test/r/create.result mysql-test/r/ctype_create.result mysql-test/r/drop.result mysql-test/r/events_2.result mysql-test/r/mysql.result mysql-test/t/create.test mysql-test/t/ctype_create.test mysql-test/t/drop.test mysql-test/t/events_2.test mysql-test/t/overflow.test sql/datadict.cc sql/partition_info.cc sql/sql_db.cc sql/sql_parse.cc sql/sql_table.cc sql/sql_yacc.yy sql/table.cc sql/table.h === modified file 'mysql-test/mysql-test-run.pl' --- a/mysql-test/mysql-test-run.pl 2012-04-27 11:48:17 +0000 +++ b/mysql-test/mysql-test-run.pl 2012-04-30 07:17:11 +0000 @@ -1735,6 +1735,10 @@ sub command_line_setup { mtr_report("Running valgrind with options \"", join(" ", @valgrind_args), "\""); + + # Turn off check testcases to save time + mtr_report("Turning off --check-testcases to save time when valgrinding"); + $opt_check_testcases = 0; } if ($opt_debug_common) No bundle (reason: useless for push emails).