List:Commits« Previous MessageNext Message »
From:Tor Didriksen Date:March 23 2012 1:37pm
Subject:bzr push into mysql-trunk branch (tor.didriksen:3845 to 3846)
View as plain text  
 3846 Tor Didriksen	2012-03-23
      Fix broken build on Mac (with MYSQL_MAINTAINER_MODE)
      sql_view.cc: In function ‘bool mysql_make_view(THD*, File_parser*, TABLE_LIST*, uint)’:
      sql_view.cc:1107: warning: ‘result’ may be used uninitialized in this function
      sql_view.cc:1106: warning: ‘parse_status’ may be used uninitialized in this function
      sql_view.cc:1102: warning: ‘view_select’ may be used uninitialized in this function

    modified:
      sql/sql_view.cc
 3845 Nuno Carvalho	2012-03-23
      BUG#13812893 - RPL.RPL_GTID_PARALLEL TEST IS TIMING OUT ON PB2
      BUG#13813422 - RPL_NON_DIRECT_STM_MIXING_ENGINES TEST TIMING OUT ON PB2
      
      Some replication tests take a long time to run, this gets worse when
      they are run on platforms such as valgrind or gcov.
      
      To avoid false failures due to timeout, now this tests are labeled as
      big. Default weekly was updated to run rpl big tests.

    modified:
      mysql-test/collections/default.weekly
      mysql-test/collections/disabled-per-push.list
      mysql-test/suite/rpl/t/rpl_gtid_parallel.test
      mysql-test/suite/rpl/t/rpl_gtid_stress_failover.test
      mysql-test/suite/rpl/t/rpl_mixed_mixing_engines.test
      mysql-test/suite/rpl/t/rpl_mixed_mts_crash_safe.test
      mysql-test/suite/rpl/t/rpl_mixed_mts_rec_crash_safe.test
      mysql-test/suite/rpl/t/rpl_mixed_mts_rec_crash_safe_checksum.test
      mysql-test/suite/rpl/t/rpl_non_direct_mixed_mixing_engines.test
      mysql-test/suite/rpl/t/rpl_non_direct_row_mixing_engines.test
      mysql-test/suite/rpl/t/rpl_non_direct_stm_mixing_engines.test
      mysql-test/suite/rpl/t/rpl_row_mixing_engines.test
      mysql-test/suite/rpl/t/rpl_row_mts_crash_safe.test
      mysql-test/suite/rpl/t/rpl_row_mts_rec_crash_safe.test
      mysql-test/suite/rpl/t/rpl_row_mysqlbinlog.test
      mysql-test/suite/rpl/t/rpl_stm_mixed_crash_safe.test
      mysql-test/suite/rpl/t/rpl_stm_mixing_engines.test
      mysql-test/suite/rpl/t/rpl_stm_mts_crash_safe.test
      mysql-test/suite/rpl/t/rpl_stm_mts_rec_crash_safe.test
=== modified file 'sql/sql_view.cc'
--- a/sql/sql_view.cc	2012-03-14 01:04:09 +0000
+++ b/sql/sql_view.cc	2012-03-23 13:36:47 +0000
@@ -1099,12 +1099,12 @@ err:
 bool mysql_make_view(THD *thd, File_parser *parser, TABLE_LIST *table,
                      uint flags)
 {
-  SELECT_LEX *end, *view_select;
+  SELECT_LEX *end, *view_select= NULL;
   LEX *old_lex, *lex;
   Query_arena *arena, backup;
   TABLE_LIST *top_view= table->top_table();
-  bool parse_status;
-  bool result, view_is_mergeable;
+  bool parse_status= true;
+  bool result= true, view_is_mergeable;
   TABLE_LIST *UNINIT_VAR(view_main_select_tables);
 
   DBUG_ENTER("mysql_make_view");

No bundle (reason: useless for push emails).
Thread
bzr push into mysql-trunk branch (tor.didriksen:3845 to 3846) Tor Didriksen26 Mar