List:Commits« Previous MessageNext Message »
From:sayantan.dutta Date:March 14 2012 10:43am
Subject:bzr push into mysql-5.5 branch (sayantan.dutta:3749 to 3750) Bug#13619394
View as plain text  
 3750 sayantan.dutta@stripped	2012-03-14
       BUG #13619394: "MAKE TEST" FAILS ON "MY_VSNPRINTF"

    modified:
      unittest/mysys/my_vsnprintf-t.c
 3749 Chaithra Gopalareddy	2012-03-14
      Bug#12626844 : WE ARE NOT CHECKING VIEW TABLE NAMES
                     ENOUGH - CONCAT() HACKS. ALSO WRONG
                     ERROR MESSAGE WHILE TRYING TO CREATE
                     A VIEW ON A NON EXISTING DATABASE
      
      PROBLEM:
      The first part of the problem is concluded as not a
      bug, as 'concat' is not a reserved word and it is
      completely valid to create a view with the name
      'concat'.
      
      The second issue is, while trying to create a view on
      a non existing database, we are not giving a proper error
      message.
      
      FIX:
      We have added a check for the database existence while
      trying to create a view. This check would give an error
      as 'unknown database' when the database does not exist.
      
      This patch is a backport of the patch for Bug#13601606
     @ mysql-test/r/view.result
        Added test case result of Bug#12626844
     @ mysql-test/t/view.test
        Added test case for Bug#12626844
     @ sql/sql_view.cc
        Added a check for database existence in mysql_create_view

    modified:
      mysql-test/r/view.result
      mysql-test/t/view.test
      sql/sql_view.cc
=== modified file 'unittest/mysys/my_vsnprintf-t.c'
--- a/unittest/mysys/my_vsnprintf-t.c	2011-06-30 15:46:53 +0000
+++ b/unittest/mysys/my_vsnprintf-t.c	2012-03-14 10:31:40 +0000
@@ -155,7 +155,7 @@ int main(void)
         "conn %ld to: '%-.64s' user: '%-.32s' host: '%-.64s' (%-.64s)",
                    1L,     NULL,          NULL,          NULL,    NULL);
   test1("Hello string `I am a string`",
-        "Hello string %`s", "I am a string");
+        "Hello string `%s`", "I am a string");
   test1("Hello TEST",
         "Hello %05s", "TEST");
   test1("My `Q` test",

No bundle (reason: useless for push emails).
Thread
bzr push into mysql-5.5 branch (sayantan.dutta:3749 to 3750) Bug#13619394sayantan.dutta14 Mar