From: Tor Didriksen Date: February 22 2012 2:31pm Subject: bzr push into mysql-trunk branch (tor.didriksen:3941 to 3942) List-Archive: http://lists.mysql.com/commits/143030 Message-Id: <201202221431.q1MEVSC6015837@acsmt358.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit 3942 Tor Didriksen 2012-02-22 fix memory leak in unit test modified: unittest/gunit/opt_range-t.cc 3941 Tor Didriksen 2012-02-22 Bug#13724099 1032 BYTE MEMORY LEAK NEW_CACHED_ITEM IN SUBQUERY WITH GROUPING OF OUTER COLUMN JOIN::cleanup didn't run delete_elements on the group_fileds list. @ sql/sql_list.h Add bool base_ilist::operator==(const base_list &rhs) const Cleanup code which was commented out. @ sql/sql_select.cc tmp_join->group_fields was emptied without running delete_elements(). Rewrote the logic for avoiding double-delete on the list. modified: mysql-test/r/func_group.result mysql-test/t/func_group.test sql/sql_list.h sql/sql_select.cc === modified file 'unittest/gunit/opt_range-t.cc' --- a/unittest/gunit/opt_range-t.cc 2012-02-09 11:22:17 +0000 +++ b/unittest/gunit/opt_range-t.cc 2012-02-22 14:30:56 +0000 @@ -140,7 +140,13 @@ public: if (item) item->save_in_field_no_warnings(this, true); } - + ~Mock_field_long() + { + bitmap_free(&share_allset); + bitmap_free(&tbl_readset); + bitmap_free(&tbl_writeset); + } + // #bytes to store the value - see Field_long::key_lenght() static const int KEY_LENGTH= 4; const char *m_table_name; No bundle (reason: useless for push emails).