From: kevin.lewis Date: January 18 2012 8:19pm Subject: bzr push into mysql-trunk branch (kevin.lewis:3747 to 3748) List-Archive: http://lists.mysql.com/commits/142469 Message-Id: <20120118201902.B1DDF1D37D3C@dhcp-adc-twvpn-2-vpnpool-10-154-48-42.vpn.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit 3748 kevin.lewis@stripped 2012-01-18 Fix a UNIV_DEBUG compile error. modified: storage/innobase/dict/dict0boot.cc 3747 kevin.lewis@stripped 2012-01-18 The primary change is to use macro constants for system table field and column numbers more consistently. The code uses hard coded numbers for both column numbers and cluster index field numbers. Contants are used very inconsistently. This patch uses the convention DICT_COL__{table_name}__{column_name) for the columns of the table and of DICT_FLD__{table_name}__{column_name) for the field numbers in the indexes. Instead of using precompiled macros, these constants are declared as enum values which the debugger can interpret. The preprocessor macros that tested the consistency of these constants are converted to debug runtime asserts. Some included files are deleted from ha_innodb.cc since they no longer need to be included directly. All other changes are just code cleanup. Patch approved by Marko in http://bur03.no.oracle.com/rb/r/877. modified: storage/innobase/dict/dict0boot.cc storage/innobase/dict/dict0crea.cc storage/innobase/dict/dict0dict.cc storage/innobase/dict/dict0load.cc storage/innobase/dict/dict0mem.cc storage/innobase/fil/fil0fil.cc storage/innobase/handler/ha_innodb.cc storage/innobase/handler/i_s.cc storage/innobase/include/dict0boot.h storage/innobase/include/dict0mem.h storage/innobase/include/dict0types.h storage/innobase/include/fil0fil.h storage/innobase/pars/pars0pars.cc storage/innobase/row/row0merge.cc storage/innobase/row/row0mysql.cc storage/innobase/srv/srv0start.cc === modified file 'storage/innobase/dict/dict0boot.cc' --- a/storage/innobase/dict/dict0boot.cc revid:kevin.lewis@stripped +++ b/storage/innobase/dict/dict0boot.cc revid:kevin.lewis@stripped @@ -271,10 +271,6 @@ dict_boot(void) ut_ad(DICT_NUM_FIELDS__SYS_FOREIGN_FOR_NAME == 2); ut_ad(DICT_NUM_COLS__SYS_FOREIGN_COLS == 4); ut_ad(DICT_NUM_FIELDS__SYS_FOREIGN_COLS == 6); - ut_ad(DICT_NUM_COLS__SYS_TABLESPACES == 3); - ut_ad(DICT_NUM_FIELDS__SYS_TABLESPACES == 5); - ut_ad(DICT_NUM_COLS__SYS_DATAFILES == 2); - ut_ad(DICT_NUM_FIELDS__SYS_DATAFILES == 4); mtr_start(&mtr); No bundle (reason: useless for push emails).