List:Commits« Previous MessageNext Message »
From:Vladislav Vaintroub Date:January 17 2012 6:38pm
Subject:RE: bzr push into mysql-trunk branch (tor.didriksen:3732 to 3733)
View as plain text  
Hi Tor,

> -----Original Message-----
> From: Tor Didriksen [mailto:tor.didriksen@stripped]
> Sent: Montag, 16. Januar 2012 12:43
> To: commits@stripped
> Subject: bzr push into mysql-trunk branch (tor.didriksen:3732 to 3733)

Hi Tor,

> +# Optionally set project name, e.g.
> +# foo.xcodeproj (mac) or foo.sln (windows)
> +SET(MYSQL_PROJECT_NAME_DOCSTRING "MySQL project name")
> +IF(DEFINED MYSQL_PROJECT_NAME)
> +  SET(MYSQL_PROJECT_NAME ${MYSQL_PROJECT_NAME} CACHE STRING
> +      ${MYSQL_PROJECT_NAME_DOCSTRING} FORCE)
> +ELSE()
> +  SET(MYSQL_PROJECT_NAME "MySQL" CACHE STRING
> +      ${MYSQL_PROJECT_NAME_DOCSTRING} FORCE)
> +  MARK_AS_ADVANCED(MYSQL_PROJECT_NAME)
> +ENDIF()
> +PROJECT(${MYSQL_PROJECT_NAME})


CACHE FORCE is not really a good style (I regret introducing it back when I
was there)
I guess you can do what you want to do simpler, with

IF(NOT MYSQL_PROJECT_NAME)
  SET(MYSQL_PROJECT_NAME "MySQL")
ENDIF()

I think you do not need to cache or document it.  It is probably better as
undocumented one-time setting  (if it should be at all) during initial cmake
run. Changing project name, e.g with cmake-gui after the initial CMake is
done sounds quite weird to be documented.
I'm curious why do you need that at all ..

Wlad

 


Thread
bzr push into mysql-trunk branch (tor.didriksen:3732 to 3733) Tor Didriksen16 Jan
  • RE: bzr push into mysql-trunk branch (tor.didriksen:3732 to 3733) Vladislav Vaintroub18 Jan
    • Re: bzr push into mysql-trunk branch (tor.didriksen:3732 to 3733)Tor Didriksen25 Jan
      • RE: bzr push into mysql-trunk branch (tor.didriksen:3732 to 3733)Vladislav Vaintroub30 Jan