List:Commits« Previous MessageNext Message »
From:Sneha Modi Date:December 22 2011 11:14am
Subject:bzr push into mysql-5.5 branch (sneha.modi:3660 to 3661) Bug#6857
Bug#11754150
View as plain text  
 3661 Sneha Modi	2011-12-22
      Bug#11754150:  A TEST CASE FOR BUG#6857 IS DISABLED IN SP.TEST
      
      unix_timestamp() is implemented in this part of the code in place of current_time().
      Also, since the pb2 machines may be extremely fast, instead of looping through the code,
      we use sleep(1.1) so that the variables t0 and t1 have different values.

    modified:
      mysql-test/r/sp.result
      mysql-test/t/sp.test
 3660 Inaam Rana	2011-12-21 [merge]
      merge from mysql-5.1

    modified:
      storage/innobase/include/ut0rnd.ic
=== modified file 'mysql-test/r/sp.result'
--- a/mysql-test/r/sp.result	2011-12-21 13:30:07 +0000
+++ b/mysql-test/r/sp.result	2011-12-22 11:09:08 +0000
@@ -2772,20 +2772,23 @@ userid
 drop procedure bug8116|
 drop table t3|
 drop procedure if exists bug6857|
-create procedure bug6857(counter int)
+create procedure bug6857()
 begin
 declare t0, t1 int;
 declare plus bool default 0;
-set t0 = current_time();
-while counter > 0 do
-set counter = counter - 1;
-end while;
-set t1 = current_time();
+set t0 = unix_timestamp();
+select sleep(1.1);
+set t1 = unix_timestamp();
 if t1 > t0 then
 set plus = 1;
 end if;
 select plus;
 end|
+call bug6857()|
+sleep(1.1)
+0
+plus
+1
 drop procedure bug6857|
 drop procedure if exists bug8757|
 create procedure bug8757()

=== modified file 'mysql-test/t/sp.test'
--- a/mysql-test/t/sp.test	2011-12-21 13:30:07 +0000
+++ b/mysql-test/t/sp.test	2011-12-22 11:09:08 +0000
@@ -3336,28 +3336,21 @@ drop table t3|
 --disable_warnings
 drop procedure if exists bug6857|
 --enable_warnings
-create procedure bug6857(counter int)
+create procedure bug6857()
 begin
   declare t0, t1 int;
   declare plus bool default 0;
 
-  set t0 = current_time();
-  while counter > 0 do
-    set counter = counter - 1;
-  end while;
-  set t1 = current_time();
+  set t0 = unix_timestamp();
+  select sleep(1.1); 
+  set t1 = unix_timestamp();
   if t1 > t0 then
     set plus = 1;
   end if;
   select plus;
 end|
 
-# QQ: This is currently disabled. Not only does it slow down a normal test
-#     run, it makes running with valgrind (or similar tools) extremely
-#     painful.
-# Make sure this takes at least one second on all machines in all builds.
-# 30000 makes it about 3 seconds on an old 1.1GHz linux.
-#call bug6857(300000)|
+call bug6857()|
 
 drop procedure bug6857|
 

No bundle (reason: useless for push emails).
Thread
bzr push into mysql-5.5 branch (sneha.modi:3660 to 3661) Bug#6857Bug#11754150Sneha Modi22 Dec