List:Commits« Previous MessageNext Message »
From:Georgi Kodinov Date:July 5 2011 4:08pm
Subject:bzr push into mysql-5.5 branch (Georgi.Kodinov:3451 to 3452) Bug#11766641
View as plain text  
 3452 Georgi Kodinov	2011-05-16
      Bug #11766641: 59792: BIN/MYSQL -UUNKNOWN -PUNKNOWN 
        .-> USING PASSWORD: NO
      
      The server was always setting the flag for using password to NO and
      then relying on the server authentication plugin to update it if it uses
      a password.
      This creates compatibility problems with 5.1 when rejecting a 
      nonexistent user login.
      Set the default for the password supplied flag for non-existing users
      as the default plugin (native password authentication) would do it
      for compatibility reasons.
      Test case added.
      federated.result updated with the correct error message.

    modified:
      mysql-test/r/plugin_auth.result
      mysql-test/suite/federated/federated.result
      mysql-test/t/plugin_auth.test
      sql/sql_acl.cc
 3451 Tor Didriksen	2011-07-04
      Bug#12710832 - PB2 DAILY-TRUNK BUILD FAILS ON SOLARIS X86_64
      
      Compiler bug:
      http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6879978
      
      Workaround is to always specify "-xOn".
     @ cmake/build_configurations/mysql_release.cmake
        Enable basic optimization for debug builds.

    modified:
      cmake/build_configurations/mysql_release.cmake
=== modified file 'mysql-test/r/plugin_auth.result'
--- a/mysql-test/r/plugin_auth.result	2011-03-31 13:08:31 +0000
+++ b/mysql-test/r/plugin_auth.result	2011-05-16 16:46:44 +0000
@@ -447,4 +447,12 @@ ORDER BY COLUMN_NAME;
 IS_NULLABLE	COLUMN_NAME
 YES	authentication_string
 YES	plugin
+#
+# Bug # 11766641: 59792: BIN/MYSQL -UUNKNOWN -PUNKNOWN 
+#  .-> USING PASSWORD: NO 
+#
+# shoud contain "using password=yes"
+ERROR 1045 (28000): Access denied for user 'unknown'@'localhost' (using password: YES)
+# shoud contain "using password=no"
+ERROR 1045 (28000): Access denied for user 'unknown'@'localhost' (using password: NO)
 End of 5.5 tests

=== modified file 'mysql-test/suite/federated/federated.result'
--- a/mysql-test/suite/federated/federated.result	2010-08-09 08:32:50 +0000
+++ b/mysql-test/suite/federated/federated.result	2011-05-16 16:46:44 +0000
@@ -60,7 +60,7 @@ CREATE TABLE federated.t1 (
 ENGINE="FEDERATED" DEFAULT CHARSET=latin1
 CONNECTION='mysql://user:pass@stripped:SLAVE_PORT/federated/t1';
 SELECT * FROM federated.t1;
-ERROR HY000: Unable to connect to foreign data source: Access denied for user 'user'@'localhost' (using password: NO)
+ERROR HY000: Unable to connect to foreign data source: Access denied for user 'user'@'localhost' (using password: YES)
 DROP TABLE federated.t1;
 CREATE TABLE federated.t1 (
 `id` int(20) NOT NULL,

=== modified file 'mysql-test/t/plugin_auth.test'
--- a/mysql-test/t/plugin_auth.test	2011-03-31 13:08:31 +0000
+++ b/mysql-test/t/plugin_auth.test	2011-05-16 16:46:44 +0000
@@ -512,4 +512,18 @@ SELECT IS_NULLABLE, COLUMN_NAME FROM INF
   ORDER BY COLUMN_NAME;
 
 
+--echo #
+--echo # Bug # 11766641: 59792: BIN/MYSQL -UUNKNOWN -PUNKNOWN 
+--echo #  .-> USING PASSWORD: NO 
+--echo #
+
+--echo # shoud contain "using password=yes"
+--error 1
+--exec $MYSQL -uunknown -punknown 2>&1
+
+--echo # shoud contain "using password=no"
+--error 1
+--exec $MYSQL -uunknown 2>&1
+
+
 --echo End of 5.5 tests

=== modified file 'sql/sql_acl.cc'
--- a/sql/sql_acl.cc	2011-07-03 23:48:19 +0000
+++ b/sql/sql_acl.cc	2011-05-16 16:46:44 +0000
@@ -8232,7 +8232,7 @@ static bool find_mpvio_user(MPVIO_EXT *m
 
   if (!mpvio->acl_user)
   {
-    login_failed_error(mpvio, 0);
+    login_failed_error(mpvio, mpvio->auth_info.password_used);
     DBUG_RETURN (1);
   }
 
@@ -8680,6 +8680,14 @@ static ulong parse_client_handshake_pack
       return packet_error;
   }
 
+  /*
+    Set the default for the password supplied flag for non-existing users
+    as the default plugin (native passsword authentication) would do it
+    for compatibility reasons.
+  */
+  if (passwd_len)
+    mpvio->auth_info.password_used= PASSWORD_USED_YES;
+
   size_t client_plugin_len= 0;
   char *client_plugin= get_string(&end, &bytes_remaining_in_packet,
                                   &client_plugin_len);

No bundle (reason: useless for push emails).
Thread
bzr push into mysql-5.5 branch (Georgi.Kodinov:3451 to 3452) Bug#11766641Georgi Kodinov5 Jul