From: Jon Olav Hauglid
Date: June 20 2011 10:36am
Subject: Re: bzr commit into mysql-trunk branch (Dmitry.Lenev:3218) Bug#12652385
List-Archive: http://lists.mysql.com/commits/139495
Message-Id: <4DFF22A4.90905@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 06/17/2011 09:08 PM, Dmitry Lenev wrote:
>   3218 Dmitry Lenev	2011-06-17
>        A follow-up for patch that fixed bug #12652385 - "61493:
>        REORDERING COLUMNS TO POSITION FIRST CAN CAUSE DATA TO
>        BE CORRUPTED".

OK to push. Thanks for taking the extra time to do this change!

Minor comment below.

> +    if (need_copy_table != ALTER_TABLE_DATA_CHANGED&&
> +        has_columns_new_or_reordered(alter_info))
> +    {
> +      /*
> +        ALTER TABLE which adds new columns (e.g. instead columns being
> +        removed) or changes their order can't be executed using in-place
> +        algorithm even if table structure stays the same.
> +      */
> +      need_copy_table= ALTER_TABLE_DATA_CHANGED;
> +    }
> +

Not sure I understand "(e.g. instead columns being removed)", word missing?

Thanks,

--- Jon Olav