From: Jorgen Loland
Date: June 16 2011 10:59am
Subject: Re: bzr commit into mysql-trunk branch (guilhem.bichot:3322) Bug#12612201
List-Archive: http://lists.mysql.com/commits/139315
Message-Id: <4DF9E21E.2030804@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Patch is OK with utility function.

On 06/09/2011 11:05 AM, Tor Didriksen wrote:
> On 2011-06-09 11:00, Guilhem Bichot wrote:
>> + if (!(thd->lex->describe
>> +#ifdef OPTIMIZER_TRACE
>> + || thd->opt_trace.support_I_S()
>> +#endif
>> + ))
>> + mysql_handle_derived(thd->lex,&mysql_derived_cleanup);
>
> there are now three of these (imho ugly) nested if/ifdef/endifs
>
> how about a utility function is_it_safe_to_cleanup_now() or something
>
> -- didrik
>

-- 
Jørgen Løland | Senior Software Engineer | +47 73842138
Oracle MySQL
Trondheim, Norway