On 06/10/11 00:45, Davi Arnaut wrote:
> On 6/9/11 6:43 AM, Alexander Nozdrin wrote:
>> #At file:///home/alik/MySQL/bzr/00/bug55843/mysql-trunk-bug55843-03/ based on
> revid:alexander.nozdrin@stripped
>>
>> 3173 Alexander Nozdrin 2011-06-09
>> Pre-requisite patch for Bug#11763162 (55843 - Handled condition
>> appears as not handled).
>>
>> Get rid of THD::set_warning_info() as a shortcut
>> to Diagnostics_area::set_warning_info().
>
> Can't we also get rid of THD::get_warning_info? It would make sense to
> get rid of these two in the same patch.
Huh... That's not really possible.
I mean, in order to get rid of THD::get_warning_info() we should either
- replace thd->get_warning_info() by thd->get_stmt_da()->get_warning_info()
which is not good.
- create facade of Warning_info in Diagnostics_area. There is a separate
patch to do that.