| List: | Commits | « Previous MessageNext Message » | |
| From: | Guilhem Bichot | Date: | June 9 2011 9:07am |
| Subject: | Re: bzr commit into mysql-trunk branch (guilhem.bichot:3322) Bug#12612201 | ||
| View as plain text | |||
Tor Didriksen a écrit, Le 09.06.2011 11:05: > On 2011-06-09 11:00, Guilhem Bichot wrote: >> + if (!(thd->lex->describe >> +#ifdef OPTIMIZER_TRACE >> + || thd->opt_trace.support_I_S() >> +#endif >> + )) >> + mysql_handle_derived(thd->lex,&mysql_derived_cleanup); > > there are now three of these (imho ugly) nested if/ifdef/endifs > > how about a utility function is_it_safe_to_cleanup_now() or something Yes, possible. Though I'd name it statement_prints_transformed_query().
| Thread | ||
|---|---|---|
| • bzr commit into mysql-trunk branch (guilhem.bichot:3322) Bug#12612201 | Guilhem Bichot | 9 Jun |
| • Re: bzr commit into mysql-trunk branch (guilhem.bichot:3322) Bug#12612201 | Tor Didriksen | 9 Jun |
| • Re: bzr commit into mysql-trunk branch (guilhem.bichot:3322) Bug#12612201 | Guilhem Bichot | 9 Jun |
| • Re: bzr commit into mysql-trunk branch (guilhem.bichot:3322) Bug#12612201 | Jorgen Loland | 16 Jun |
