List:Commits« Previous MessageNext Message »
From:Jon Olav Hauglid Date:June 9 2011 8:11am
Subject:Re: bzr commit into mysql-trunk branch (alexander.nozdrin:3170) Bug#11763162
View as plain text  
Hello,

On 06/08/2011 07:27 PM, Alexander Nozdrin wrote:
>   3170 Alexander Nozdrin	2011-06-08
>        Pre-requisite patch for Bug#11763162 (55843 - Handled condition
>        appears as not handled).
>
>        The goal of this patch is to change the relationship between THD,
>        Diagnostics_area and Warning_info classes:
>
>          - before the patch, THD owned both Diagnostics_area and
>            Warning_info instances.
>
>          - after the patch THD owns Diagnostics_area instance,
>            and Diagnostics_area owns Warning_info instance.
>
>        The patch changes THD::get_warning_info() and THD::set_warning_info(),
>        so that they still work to minimize side changes.

Eh... THD::set_warning_info() is gone, right?

>        Those functions will be removed later in a separate patch.
>       @ sql/sp_head.cc
>          Note: Warning_info is pushed here alone (without Diagnistics_area).

Diagnistics => Diagnostics (and two places below as well).

>          Temporary Warning_info instance is used to collect warnings
>          from stored-routine-execution and append them to the main
>          Warning_info area.
>       @ sql/sql_admin.cc
>          Note: Warning_info is pushed here alone (without Diagnistics_area).
>          Temporary Warning_info instance is used to collect unneeded
>          warnings and ignore them.
>       @ sql/sql_prepare.cc
>          Note: Diagnostics_area is pushed here along with
>          a new instance of Warning_info.
>       @ sql/sql_show.cc
>          Note: Warning_info is pushed here alone (without Diagnistics_area).
>          Temporary Warning_info instance is used to collect warnings
>          from ST_SHEMA_TABLE::fill_table() and process them afterwards.

ST_SCHEMA_TABLE?

Check with Davi that these Notes give the information that he was 
looking for. I don't quite see the point of them in their current state, 
but I'm quite sure what Davi was looking for either :-)

Otherwise I have no issues with this patch.

Thanks,

--- Jon Olav
Thread
bzr commit into mysql-trunk branch (alexander.nozdrin:3170) Bug#11763162Alexander Nozdrin9 Jun
  • Re: bzr commit into mysql-trunk branch (alexander.nozdrin:3170) Bug#11763162Jon Olav Hauglid9 Jun