From: Alexander Nozdrin
Date: June 8 2011 12:08pm
Subject: Re: bzr commit into mysql-trunk branch (alexander.nozdrin:3168) Bug#11763162
List-Archive: http://lists.mysql.com/commits/138836
Message-Id: <4DEF664E.5040400@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On 06/07/11 21:31, Davi Arnaut wrote:
> On 6/7/11 1:14 PM, Alexander Nozdrin wrote:
>> #At file:///home/alik/MySQL/bzr/00/bug55843/mysql-trunk-bug55843-01/ based on revid:alexander.nozdrin@stripped
>>
>>   3168 Alexander Nozdrin	2011-06-07
>>        Pre-requisite patch for Bug#11763162 (55843 - Handled condition
>>        appears as not handled).
>>
>>        Rename Diagnostics_area::statement_warn_count() to da_statement_warn_count()
>>        in order to distinguish from Warning_info::statement_warn_count().
> 
> They are already distinguished by the fact that they are member of
> different objects.

Further patch will introduce

uint Diagnostics_area::statement_warn_count()
{ return get_warning_info()->statement_warn_count(); }

(and others proxy-functions like this).

Thus, this name is taken.

> This also makes the naming patter of this one
> function different from all the others in Diagnostics_area.

Right. What can be a better name?

> Please drop this unless it's strictly necessary.

I can't see how we can have a facade of Warning_info in Diagnostics_are
without renaming Diagnostics_area::statement_warn_count().