List:Commits« Previous MessageNext Message »
From:Alexander Nozdrin Date:June 8 2011 9:54am
Subject:Re: bzr commit into mysql-trunk branch (alexander.nozdrin:3165) Bug#11763162
View as plain text  
Hello,

On 06/07/11 18:24, Jon Olav Hauglid wrote:
> On 06/07/2011 03:09 PM, Alexander Nozdrin wrote:
>>    3165 Alexander Nozdrin	2011-06-07
>>         Pre-requisite patch for Bug#11763162 (55843 - Handled condition
>>         appears as not handled).
>>
>>         Make THD::stmt_da and THD::warning_info private,
>>         and provide getters for them:
>>           - THD::get_stmt_da()
>>           - THD::set_stmt_da()
>>           - THD::get_warning_info()
>>           - THD::set_warning_info()
> 
> This patch looks ok to me. I'd prefer the use of get/set also inside
> the THD class, but that's a minor issue and not a requirement from me.

I can do that if Davi doesn't mind.

> But, I'd like to review all patches before you start pushing anything.

sure.
Thread
bzr commit into mysql-trunk branch (alexander.nozdrin:3165) Bug#11763162Alexander Nozdrin7 Jun
  • Re: bzr commit into mysql-trunk branch (alexander.nozdrin:3165) Bug#11763162Jon Olav Hauglid7 Jun
    • Re: bzr commit into mysql-trunk branch (alexander.nozdrin:3165) Bug#11763162Alexander Nozdrin8 Jun
  • Re: bzr commit into mysql-trunk branch (alexander.nozdrin:3165) Bug#11763162Davi Arnaut7 Jun
    • Re: bzr commit into mysql-trunk branch (alexander.nozdrin:3165) Bug#11763162Alexander Nozdrin8 Jun