From: Jon Olav Hauglid Date: June 7 2011 2:24pm Subject: Re: bzr commit into mysql-trunk branch (alexander.nozdrin:3165) Bug#11763162 List-Archive: http://lists.mysql.com/commits/138791 Message-Id: <4DEE348D.4050405@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hello, On 06/07/2011 03:09 PM, Alexander Nozdrin wrote: > 3165 Alexander Nozdrin 2011-06-07 > Pre-requisite patch for Bug#11763162 (55843 - Handled condition > appears as not handled). > > Make THD::stmt_da and THD::warning_info private, > and provide getters for them: > - THD::get_stmt_da() > - THD::set_stmt_da() > - THD::get_warning_info() > - THD::set_warning_info() This patch looks ok to me. I'd prefer the use of get/set also inside the THD class, but that's a minor issue and not a requirement from me. But, I'd like to review all patches before you start pushing anything. (And Davi must of course also approve :-) ) --- Jon Olav