List:Commits« Previous MessageNext Message »
From:Guilhem Bichot Date:June 7 2011 8:10am
Subject:Re: bzr commit into mysql-trunk branch (guilhem.bichot:3158) WL#5914
View as plain text  
Hello,

> On 06/06/2011 02:33 PM, Guilhem Bichot wrote:
>> #At file:///home/mysql_src/bzrrepos_new/wl5914_trunk/ based on
> revid:guilhem.bichot@stripped
>>
>>  3158 Guilhem Bichot	2011-06-06
>>       This patch is for trunk.
>>       WL#5914 remove option "--all" of the "perror" program.
>>       This removes printing of BDB errors, a compiler warnings about sys_nerr*.
> 
> This commit message says that you remove printing of BDB errors. These 
> are still available in the patch. No harm to still have them in perror, 
> but since we no longer support BDB it could be an opportunity to remove 
> a few more lines of code by removing them completely? (up to you).

done (see new patch)

>> -#ifdef HAVE_SYS_ERRLIST
>> -  {"all", 'a', "Print all the error messages and the number.",
>> -   &print_all_codes, &print_all_codes, 0, GET_BOOL, NO_ARG,
>> -   0, 0, 0, 0, 0, 0},
>> -#endif
> 
> It seems like perror.c is the only source file that uses 
> HAVE_SYS_ERRLIST so maybe we should remove the check for support for 
> this from our Cmake files?

done (see new patch)
Thread
bzr commit into mysql-trunk branch (guilhem.bichot:3158) WL#5914Guilhem Bichot6 Jun
  • Re: bzr commit into mysql-trunk branch (guilhem.bichot:3158) WL#5914Olav Sandstaa7 Jun
    • Re: bzr commit into mysql-trunk branch (guilhem.bichot:3158) WL#5914Guilhem Bichot7 Jun
  • Re: bzr commit into mysql-trunk branch (guilhem.bichot:3158) WL#5914Davi Arnaut7 Jun
Re: bzr commit into mysql-trunk branch (guilhem.bichot:3158) WL#5914Davi Arnaut7 Jun
Re: bzr commit into mysql-trunk branch (guilhem.bichot:3158) WL#5914Guilhem Bichot7 Jun