Hi Guilhem,
Patch looks good. OK to push.
Minor detail: if you need to re-commit before pushing you can consider
to update the copyright header to include Oracle instead of MySQL AB.
Olav
On 06/06/2011 02:34 PM, Guilhem Bichot wrote:
> #At file:///home/mysql_src/bzrrepos_new/wl5914_5.5/ based on
> revid:georgi.kodinov@stripped
>
> 3429 Guilhem Bichot 2011-06-06
> This patch is for 5.5.
> WL#5914 remove option "--all" of the "perror" program.
> In 5.5 we just give a deprecation warning; in trunk we remove the option.
>
> modified:
> extra/perror.c
> === modified file 'extra/perror.c'
> --- a/extra/perror.c 2011-03-29 12:43:49 +0000
> +++ b/extra/perror.c 2011-06-06 12:34:23 +0000
> @@ -64,7 +64,8 @@ static struct my_option my_long_options[
> &ndb_code, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
> #endif
> #ifdef HAVE_SYS_ERRLIST
> - {"all", 'a', "Print all the error messages and the number.",
> + {"all", 'a', "Print all the error messages and the number. Deprecated,"
> + " will be removed in a future release.",
> &print_all_codes,&print_all_codes, 0, GET_BOOL, NO_ARG,
> 0, 0, 0, 0, 0, 0},
> #endif
> @@ -295,6 +296,8 @@ int main(int argc,char *argv[])
> if (print_all_codes)
> {
> HA_ERRORS *ha_err_ptr;
> + printf("WARNING: option '-a/--all' is deprecated and will be removed in a"
> + " future release.\n");
> for (code=1 ; code< sys_nerr ; code++)
> {
> if (sys_errlist[code]&& sys_errlist[code][0])
>
>
>
>