From: Roy Lyseng
Date: June 1 2011 1:35pm
Subject: Re: bzr commit into mysql-trunk branch (olav.sandstaa:3135) Bug#12355958
List-Archive: http://lists.mysql.com/commits/138552
Message-Id: <4DE6401E.803@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Olav,

On 01.06.11 15.23, Olav Sandstaa wrote:
> Hi Roy,
>
> On 01/06/2011 15:11, Roy Lyseng wrote:
>> Hi Olav,
>>
>> I like this naming for the new access function.
>>
>> When shuffling fields in the Item struct, please make sure that the size of
>> the struct does not increase (I do not think it will, though).
>
> Good idea. I have now verified (using Sun Studio on Solaris) that the size of
> the Item object is 80 byte both before and after this change (in a 32 bit
> binary). I will do the same test using gcc on Linux before pushing the fix.
>
> One question: The type of the with_subselect variable is "my_bool". Should I
> have used the opportunity to change this to a real "bool"? (I have verified that
> that will not increase the size of the Item object)

Considering that there are 6 other "my_bool" fields in the object, I'd say this 
should rather be a separate patch. But definitely a good idea to carry out some 
time...

Thanks,
Roy