List:Commits« Previous MessageNext Message »
From:Tor Didriksen Date:May 27 2011 8:05am
Subject:Re: bzr commit into mysql-trunk branch (tor.didriksen:3102) Bug#11765562
View as plain text  
On 2011-05-27 00:31, Gleb Shchepa wrote:
> Hello Tor,
>
> Your fix looks good.
> The only issue: do you really need to combine refactoring and bugfixing?
> All these code beautifications do nothing with the reported problem.
> IMO the minimal patch is better, but it's up to you.

Thanks gleb.
I agree that bugfix-patches should be small,
but I also think it is natural to do small readability improvements 
while bugfixing.
Swapping 'null_value=1;' with 'null_value=true;' isn't really a big 
refactoring :-)

-- didrik


Thread
bzr commit into mysql-trunk branch (tor.didriksen:3102) Bug#11765562Tor Didriksen19 May
  • Re: bzr commit into mysql-trunk branch (tor.didriksen:3102) Bug#11765562Gleb Shchepa27 May
    • Re: bzr commit into mysql-trunk branch (tor.didriksen:3102) Bug#11765562Gleb Shchepa27 May
    • Re: bzr commit into mysql-trunk branch (tor.didriksen:3102) Bug#11765562Tor Didriksen27 May