List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:May 26 2011 2:07pm
Subject:Re: bzr commit into mysql-5.5 branch (Dmitry.Lenev:3404) Bug#11762012
View as plain text  
On 5/26/11 7:57 AM, Dmitry Lenev wrote:
> #At file:///home/dlenev/src/bzr/mysql-5.5-11762012/ based on
> revid:anitha.gopi@stripped
>
>   3404 Dmitry Lenev	2011-05-26
>        Fix for bug #11762012 - "54553: INNODB ASSERTS IN
>        HA_INNOBASE::UPDATE_ROW, TEMPORARY TABLE, TABLE LOCK".
>

OK to push. Some minor wording suggestions below.

>
> === modified file 'sql/sql_parse.cc'
> --- a/sql/sql_parse.cc	2011-05-21 08:21:08 +0000
> +++ b/sql/sql_parse.cc	2011-05-26 10:57:08 +0000
> @@ -1749,6 +1749,64 @@ bool sp_process_definer(THD *thd)
>
>
>   /**
> +  Auxiliary call that opens and locks tables for LOCK TABLES statement
> +  and inits list of locked tables.

inits -> "initializes the list"

> +  @param thd     Thread context.
> +  @param tables  List of tables to be locked.
> +
> +  @return FALSE in case of success, TRUE in case of error.
> +*/
> +
> +static bool lock_tables_open_and_lock_tables(THD *thd, TABLE_LIST *tables)
> +{
> +  Lock_tables_prelocking_strategy lock_tables_prelocking_strategy;
> +  uint counter;
> +  TABLE_LIST *table;
> +
> +  thd->in_lock_tables= 1;
> +
> +  if (open_tables(thd,&tables,&counter,
> 0,&lock_tables_prelocking_strategy))
> +    goto err;
> +
> +  /*
> +    We allow to change temporary tables even if they were locked for read
> +    by LOCK TABLES. To avoid discrepancy between lock acquired at LOCK TABLES

"a discrepancy"

> +    time and by the statement which is later executed under LOCK TABLES we
> +    ensure that for temporary tables we always request write lock (such a

"request a write lock"

> +    discrepancy can cause problems in storage engine).

"such discrepancy" "for the storage"

Regards,

Davi
Thread
bzr commit into mysql-5.5 branch (Dmitry.Lenev:3404) Bug#11762012Dmitry Lenev26 May
  • Re: bzr commit into mysql-5.5 branch (Dmitry.Lenev:3404) Bug#11762012Davi Arnaut26 May