From: Martin Hansson
Date: May 24 2011 11:02am
Subject: Re: bzr commit into mysql-trunk branch (martin.hansson:3368)
List-Archive: http://lists.mysql.com/commits/137969
Message-Id: <4DDB903B.50806@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Roy Lyseng skrev 2011-05-24 11.09:
> On 24.05.11 10.40, Jorgen Loland wrote:
>> Martin Hansson wrote:
>>> #At file:///data0/martin/bzrroot/wl5855/mysql-trunk-prototype/ based on
>>> revid:azundris@stripped
>>>
>>> 3368 Martin Hansson 2011-05-23
>>> Replaced the st_join_table typedef with a C++ class declaration.
>>
>> +1!
Hehe, this was actually not intended for anyone to see. I just needed to 
do this in order to comfortably start prototyping wl#5855. But 
apparently, it is in demand. May I push?
>>
>> Feel free to encapsulate as well :)
I have to leave some fun for the rest of you lot, don't I?

>>
>>
>
> JOIN_TAB is not in compliance with our class naming rules.
True. But regardless of what other name I might pick it would cause 
controversy, not to mention all documentation that would have to be 
rewritten, or the merge conflicts. At least it is consistent with class 
JOIN, and a step in the right direction IMHO.

/Martin