List:Commits« Previous MessageNext Message »
From:Alfranio Correia Date:May 24 2011 7:50am
Subject:Re: bzr commit into mysql-trunk branch (alfranio.correia:3376) WL#4143
View as plain text  
Hi Bjorn,

Thank you for the feedback.

On 05/24/2011 08:43 AM, Bjorn Munch wrote:
> On 23/05 20.31, Alfranio Correia wrote:
>> === modified file 'mysql-test/include/mtr_warnings.sql'
>> --- a/mysql-test/include/mtr_warnings.sql	2011-04-06 10:36:10 +0000
>> +++ b/mysql-test/include/mtr_warnings.sql	2011-05-23 20:31:04 +0000
>> @@ -211,6 +211,12 @@ INSERT INTO global_suppressions VALUES
>>   */
>>   (".*If a crash happens this configuration does not guarantee.*"),
>>  
>> + /*
>> +   Warning messages introduced in the context of the WL#4143.
>> + */
>> + ("Due to security issues one must use SSL/TSL while specifying START SLAVE
> USER=xxx PASSWORD=yyy."),
>> + ("It is not recommend to store user and password in the master info repository
> due to security issues.*"),
> 
> Are these general warnings which can now show up in many tests? If
> they're specific to this test, plase add them to the test instead:
> 
> call mtr.add_suppression("<text>");

These warning messages are not specific to this test and will pop up in all tests that
call START SLAVE
and CHANGE MASTER, i.e. all replication tests.

> 
>> === added file 'mysql-test/suite/rpl/r/rpl_master_connection.result'
>> --- a/mysql-test/suite/rpl/r/rpl_master_connection.result
>> 1970-01-01 00:00:00 +0000
> 
> [......]
> 
>> +START SLAVE USER= 'root' PASSWORD= '' DEFAULT_AUTH= 'auth_test_plugin'
> PLUGIN_DIR=
> '/home/acorreia/workspace.oracle/repository.mysql/bzrwork/wl-4143/mysql-trunk/plugin/auth';
> 
> Uh-oh, explicit paths in the result file, this is not going to work!
> You should preceed the corresponding line in .test with something like
> this:
> 
> --replace_result $PLUGIN_AUTH_DIR PLUGIN_DIR

Sure, I thought I had done this.

Cheers.

> 
> - Bjorn

Thread
bzr commit into mysql-trunk branch (alfranio.correia:3376) WL#4143Alfranio Correia23 May
  • Re: bzr commit into mysql-trunk branch (alfranio.correia:3376)WL#4143Bjorn Munch24 May
    • Re: bzr commit into mysql-trunk branch (alfranio.correia:3376) WL#4143Alfranio Correia24 May