List:Commits« Previous MessageNext Message »
From:Dmitry Lenev Date:May 23 2011 7:38pm
Subject:Re: Fwd: bzr commit into mysql-5.1 branch (Dmitry.Shulga:3625)
Bug#45235 Bug#11753738
View as plain text  
Hello Dmitry!

> #At file:///Users/shulga/projects/mysql/mysql-5.1-bug11753738/ based on
> revid:luis.soares@stripped
> 
>  3625 Dmitry Shulga	2011-05-23
>       Fixed bug#11753738 (formely known as bug#45235) - 5.1 DOES NOT SUPPORT
> 5.0-ONLY
>       SYNTAX TRIGGERS IN ANY WAY

> === modified file 'mysql-test/t/trigger-compat.test'
> --- a/mysql-test/t/trigger-compat.test	2009-02-19 23:24:25 +0000
> +++ b/mysql-test/t/trigger-compat.test	2011-05-23 11:39:31 +0000

...

> +
> +--echo # We write three trigger files. First trigger is syntaxically incorrect, next
> trigger is correct
> +--echo # and last trigger is broken.
> +--echo # Next we try to execute SHOW CREATE TRGGIR command for broken trigger and
> then try to drop one.
                                               ^^^^^^
Typo:                                          TRIGGER

...

Otherwise your patch looks OK.

I think that it can be pushed into the tree once you get
approval from the second reviewer.

-- 
Dmitry Lenev, Software Developer
Oracle Development SPB/MySQL, www.mysql.com

Are you MySQL certified?  http://www.mysql.com/certification
Thread
Re: Fwd: bzr commit into mysql-5.1 branch (Dmitry.Shulga:3625)Bug#45235 Bug#11753738Dmitry Lenev23 May