From: Tor Didriksen
Date: May 23 2011 7:12am
Subject: bzr commit into mysql-trunk branch (tor.didriksen:3313)
List-Archive: http://lists.mysql.com/commits/137840
Message-Id: <20110523071214.ED12B37A6@atum07.norway.sun.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6993601702348501509=="

--===============6993601702348501509==
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

#At file:///export/home/didrik/repo/next-mr-opt-backporting-wl4800/ based on revid:guilhem.bichot@stripped

 3313 Tor Didriksen	2011-05-23
      comments on TODO list

    modified:
      WL4800_TODO.txt
      sql/opt_trace.h
=== modified file 'WL4800_TODO.txt'
--- a/WL4800_TODO.txt	2011-05-20 13:15:22 +0000
+++ b/WL4800_TODO.txt	2011-05-23 07:12:10 +0000
@@ -27,6 +27,7 @@ version number in order to distinguish b
 not forget to bump the version when doing certain changes (and: what
 changes? any little change? maybe).
 Guilhem suggests: don't have a version.
+I agree.
 
 C3) Jorgen wrote: The optimizer may have second thoughts about which access method to
 use for a table. This should be traced. See example query (1) where
@@ -43,12 +44,14 @@ Guilhem asks: good idea, but how much is
 --explain-protocol, --sp-protocol, --view-protocol make all tests
 fail. Maybe I can merely move this as an idea in a comment in mysqltest.cc
 near the definition of opt-trace-protocol?
+This would be a relly nice feature. Don't know how much work it is though.
 
 C5) should the debug binary really assert(0) if json syntax error? is it a
 good idea at the customer's? On the other hand, how to make sure a
 developer notices a syntax error when running tests?
 sql_print_warning() is an idea.
 Guilhem suggests: keep it as it is (assert(0))
+Let's keep it, at least for now.
 
 C7) Dmitry advised we should trace SET and DO. Right now SET-which-sets-local-routine-vars is
 traced, but SET-which-sets-other-vars is not, this is
@@ -58,6 +61,7 @@ Guilhem says: agree. A drawback of this 
 SET optimizer_trace="enabled=off";
 will be traced, which is a nuisance, as it deletes previous trace.
 But next item below which could eliminate this drawback.
+I don't have an opinion on this one.
 
 C8) should we limit tracing to statements using
 tables/views? This would decrease the noise when tracing a routine
@@ -70,3 +74,4 @@ The worst consequence it could have is t
   SELECT stored_func();
 would not be traced (but its substatements would still be, if they use
 tables/views).
+I don't have an opinion on this one.

=== modified file 'sql/opt_trace.h'
--- a/sql/opt_trace.h	2011-05-20 13:03:28 +0000
+++ b/sql/opt_trace.h	2011-05-23 07:12:10 +0000
@@ -934,7 +934,7 @@ void opt_trace_print_expanded_query(THD 
                                     st_select_lex *select_lex);
 
 void opt_trace_disable_if_no_view_access(THD *thd, TABLE_LIST *view,
-                                 TABLE_LIST *underlying_tables);
+                                         TABLE_LIST *underlying_tables);
 
 void opt_trace_disable_if_no_stored_proc_func_access(THD *thd, sp_head *sp);
 


--===============6993601702348501509==
MIME-Version: 1.0
Content-Type: text/bzr-bundle; charset="us-ascii";
	name="bzr/tor.didriksen@stripped"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: tor.didriksen@stripped\
#   comgsoj9moxqzo4f
# target_branch: file:///export/home/didrik/repo/next-mr-opt-\
#   backporting-wl4800/
# testament_sha1: 6eb45183b89c8c1a7fcfa2d4743b04321da49fd8
# timestamp: 2011-05-23 09:12:14 +0200
# base_revision_id: guilhem.bichot@stripped\
#   i9y31pxnvuf8q7ds
# 
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWVZgqAMAAi5fgEAQUvf//3Yk
jIC////wUAT4vHXKtveee1Me9qtcEkgppPCZMVP1T9NGqfqNR6Yo09QNqGmaR6gyinpkNMTEmp6j
TJ6hpoAYQBoASgkwptJiZTaNUG0gaA0PUPUGgAkVNNEn6Q0aTTRo0GEwhkAAAEkiZAJqeTJqemph
GmkPUeoeo9QNDQXbUuzz8Dgpx6dR3HFqBXjlrBCCIkCvEexldIQmuKS7cj2mQqqIq9OaB3wl16Oq
l67VsgxYzO7KrrP8cG5+tTlzcdLun9Y/kWh3/pznHeT2xuFFGgdFRHIfddmPaQnw9t3cYHJOZIyk
oTp6HQeMpj0QrD0hLOBRn3KqOg3DuFerHP87CFriwuQ4SmQMs/IwL7a4j54IyZGtguQM+QtkRgnM
yAcxJcQ7jCKE8GhFgKTFDpFBTFJUekkGZVpFLMbKgMoh0lQvp3B3IorIKDSYULs6AAxwunUNgoei
e8XgNied8LaJjpoHHaGzCUa1q1QSDqtuLqSAYTT34sgMSqADlA0ZRQSmG5jOri247ESlsHrFWlBi
oHnd6lTwpfw13uSlcOMKbdkpmuWsWLXf0lTxZYXFI2yOpTIN9OeiAapjS6/8bFTKZKW0sIYOKba9
4Ep6ESQVESmyRCyiFignLgSpqZwxQpbYlpidl+v7PJhphurseZHMgW2mglpKQ1ZYF2GFIapSzwPG
yeq/tZ0oHC6+PS6UcXvuKSIxAunTwlQnkwpkWvIsmoFIqS52BqqYhJXSKbJEUtfMnjhlcNwFLPHq
Boj5bEvKsU68UGizJOTA6HOqUUUunduVmy+qh4lzDM/mc9KIoO2mTbGZvLz8CgjvzJumPrDoTHj6
+U0knztpxpsLHC5+MA55hyn+hEWGXY42bcx14nyJuJxX5kcJTbyNcEVcbSV5CvwnSp4xYdA73F9s
xyYc4OruRRiTdUTV7dwiougSnQ0c44v1lY9uzabYmVSgT9TRDBkRZkk2kSeBcdg1yhaLRPj0GLEL
lohjICsD+CVELYM2mTa8L67yBmMzmYlIjsTPt6lV5Nc214lBMV137rE7335z2Fw7LcLHlajUhMA4
jDVkoyjFwdpyqsrkgew4GNhii7ekWRIaCOWCtcEbrqpH5XY3yn2kmRZKiOlFzG0pa03pltitCq/x
uIkbdD13HB5gJp3zvhUBmRlqNmXemwbUJtBNmjI+PCKHx7ThigkWeC2YNFDpZOaOnegfO5YmdAjW
LNESzV4otk895/O/XG8zRxKm3I2PNMB+ByAz7tTTTa0OfKZiN5znDzVaK3hrlJxJgo3OQ7xzjKc1
wxQSCC9orp7KGWlxEDsIcnPRMCc0pv7t2Vyupbw0oMggcTVGKMEVVBTypcDLCvNdtioaGvJQ0nEC
wv4k+sDJC3skaKhig8noeUzDi3n9213rqD+EmjogtZBXkY3HTM98DE8JXxsYRnVrOzOrZCWAeCm5
beicUFdOW4Cg31uQWr1YJ6QeF1l86WDTBS1ZREoNYdFyiyihH7HME82GaS4BF2DysqLSFJhLEDsJ
T3LOgj21IK+kYKxfi1mCDjhBL6Qddga2tspaKxyNBYmT9dtFaoTKWF+W1d5y8mwxv5LTrQ3DrVfG
gpV+jWh6lOA1HC/VlsNxn7+1SgaVQLXUxyTrInR1uKmfWBLf8D/i7kinChIKzBUAYA==


--===============6993601702348501509==--