List:Commits« Previous MessageNext Message »
From:Tor Didriksen Date:May 23 2011 7:12am
Subject:bzr commit into mysql-trunk branch (tor.didriksen:3313)
View as plain text  
#At file:///export/home/didrik/repo/next-mr-opt-backporting-wl4800/ based on revid:guilhem.bichot@stripped

 3313 Tor Didriksen	2011-05-23
      comments on TODO list

    modified:
      WL4800_TODO.txt
      sql/opt_trace.h
=== modified file 'WL4800_TODO.txt'
--- a/WL4800_TODO.txt	2011-05-20 13:15:22 +0000
+++ b/WL4800_TODO.txt	2011-05-23 07:12:10 +0000
@@ -27,6 +27,7 @@ version number in order to distinguish b
 not forget to bump the version when doing certain changes (and: what
 changes? any little change? maybe).
 Guilhem suggests: don't have a version.
+I agree.
 
 C3) Jorgen wrote: The optimizer may have second thoughts about which access method to
 use for a table. This should be traced. See example query (1) where
@@ -43,12 +44,14 @@ Guilhem asks: good idea, but how much is
 --explain-protocol, --sp-protocol, --view-protocol make all tests
 fail. Maybe I can merely move this as an idea in a comment in mysqltest.cc
 near the definition of opt-trace-protocol?
+This would be a relly nice feature. Don't know how much work it is though.
 
 C5) should the debug binary really assert(0) if json syntax error? is it a
 good idea at the customer's? On the other hand, how to make sure a
 developer notices a syntax error when running tests?
 sql_print_warning() is an idea.
 Guilhem suggests: keep it as it is (assert(0))
+Let's keep it, at least for now.
 
 C7) Dmitry advised we should trace SET and DO. Right now SET-which-sets-local-routine-vars is
 traced, but SET-which-sets-other-vars is not, this is
@@ -58,6 +61,7 @@ Guilhem says: agree. A drawback of this 
 SET optimizer_trace="enabled=off";
 will be traced, which is a nuisance, as it deletes previous trace.
 But next item below which could eliminate this drawback.
+I don't have an opinion on this one.
 
 C8) should we limit tracing to statements using
 tables/views? This would decrease the noise when tracing a routine
@@ -70,3 +74,4 @@ The worst consequence it could have is t
   SELECT stored_func();
 would not be traced (but its substatements would still be, if they use
 tables/views).
+I don't have an opinion on this one.

=== modified file 'sql/opt_trace.h'
--- a/sql/opt_trace.h	2011-05-20 13:03:28 +0000
+++ b/sql/opt_trace.h	2011-05-23 07:12:10 +0000
@@ -934,7 +934,7 @@ void opt_trace_print_expanded_query(THD 
                                     st_select_lex *select_lex);
 
 void opt_trace_disable_if_no_view_access(THD *thd, TABLE_LIST *view,
-                                 TABLE_LIST *underlying_tables);
+                                         TABLE_LIST *underlying_tables);
 
 void opt_trace_disable_if_no_stored_proc_func_access(THD *thd, sp_head *sp);
 


Attachment: [text/bzr-bundle] bzr/tor.didriksen@oracle.com-20110523071210-comgsoj9moxqzo4f.bundle
Thread
bzr commit into mysql-trunk branch (tor.didriksen:3313) Tor Didriksen23 May
  • Re: bzr commit into mysql-trunk branch (tor.didriksen:3313)Guilhem Bichot23 May