From: Jon Olav Hauglid
Date: May 16 2011 2:19pm
Subject: Re: bzr commit into mysql-trunk branch (davi:3091)
List-Archive: http://lists.mysql.com/commits/137449
Message-Id: <4DD13275.40801@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 05/16/2011 03:30 PM, Davi Arnaut wrote:
>   3091 Davi Arnaut	2011-05-16
>        Fix warnings emitted by Clang.

Ok to push with a few comments below.

Please remember to update copyright headers.

>       @ sql/rpl_injector.cc
>          transaction does not implement a copy constructor.

The comment above could be clarified/extended.

> === modified file 'sql/rpl_injector.h'
> --- a/sql/rpl_injector.h	2011-02-01 08:51:58 +0000
> +++ b/sql/rpl_injector.h	2011-05-16 13:30:44 +0000
> @@ -344,13 +344,10 @@ public:
>          two calls are equivalent, with the exception that the latter will
>          overwrite the transaction.
>
> -         injector::transaction trans1= inj->new_trans(thd);
> -
>            injector::transaction trans2;
>            inj->new_trans(thd,&trans);
>        */

I think the comment above needs to be adjusted even more?

> === modified file 'storage/innobase/handler/i_s.cc'
> --- a/storage/innobase/handler/i_s.cc	2011-04-27 21:49:19 +0000
> +++ b/storage/innobase/handler/i_s.cc	2011-05-16 13:30:44 +0000
> @@ -151,7 +151,8 @@ do {									\
>   	}								\
>   } while (0)
>
> -#if !defined __STRICT_ANSI__&&  defined __GNUC__&&  (__GNUC__)>  2&&  !defined __INTEL_COMPILER
> +#if !defined __STRICT_ANSI__&&  defined __GNUC__&&  (__GNUC__)>  2&&	\
> +	!defined __INTEL_COMPILER&&  !defined __clang__
>   #define STRUCT_FLD(name, value)	name: value
>   #else
>   #define STRUCT_FLD(name, value)	value

Maybe notify #innodb about this change?

Otherwise looks ok.

--- Jon Olav