From: Alexander Nozdrin Date: May 16 2011 8:55am Subject: bzr push into mysql-5.5 branch (alexander.nozdrin:3383 to 3385) List-Archive: http://lists.mysql.com/commits/137389 Message-Id: <201105160856.p4G8txsk006675@acsmt356.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit 3385 Alexander Nozdrin 2011-05-16 Ignore auto-generated files. modified: .bzrignore 3384 Alexander Nozdrin 2011-05-16 A patch for Bug#12429877: QUERY_TABLES_LIST::SROUTINES IS NOT FREED IN FLUSH_READ_LOCK (VALGRIND WARNING). The problem was that under some circustances the memory allocated for Query_tables_list::sroutines was not freed properly. The cause of this problem was the absence of LEX::restore_backup_query_tables_list() call in one of the branches in mysql_table_grant() function. modified: sql/sql_acl.cc 3383 Vinay Fisrekar 2011-05-14 [merge] Merge from mysql-5.1 to mysql-5.5 added: mysql-test/r/implicit_char_to_num_conversion.result mysql-test/t/implicit_char_to_num_conversion.test === modified file '.bzrignore' --- a/.bzrignore 2011-05-11 12:45:57 +0000 +++ b/.bzrignore 2011-05-16 08:51:14 +0000 @@ -3132,3 +3132,4 @@ VERSION.dep info_macros.cmake Docs/INFO_BIN Docs/INFO_SRC +Testing === modified file 'sql/sql_acl.cc' --- a/sql/sql_acl.cc 2011-03-21 14:22:13 +0000 +++ b/sql/sql_acl.cc 2011-05-16 08:50:42 +0000 @@ -3644,6 +3644,7 @@ int mysql_table_grant(THD *thd, TABLE_LI { // Should never happen /* Restore the state of binlog format */ DBUG_ASSERT(!thd->is_current_stmt_binlog_format_row()); + thd->lex->restore_backup_query_tables_list(&backup); if (save_binlog_row_based) thd->set_current_stmt_binlog_format_row(); DBUG_RETURN(TRUE); /* purecov: deadcode */ No bundle (reason: useless for push emails).