From: Jon Olav Hauglid
Date: May 13 2011 7:36am
Subject: Re: bzr commit into mysql-trunk branch (tor.didriksen:3372) Bug#11788245
List-Archive: http://lists.mysql.com/commits/137284
Message-Id: <4DCCDF80.7000901@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 05/12/2011 04:41 PM, Tor Didriksen wrote:
>   3372 Tor Didriksen	2011-05-12
>        Bug #11788245 - 60110 DO MORE THD AND GLOBAL INITIALIZATION FOR UNIT TESTING

Ok to push.

Two nitpicks below.

>        Move server/THD initialization to separate utility classes in namespace my_testing.

Maybe you could mention that the patch also adds a new unit test.

> === added file 'unittest/gunit/opt_range-t.cc'
> --- a/unittest/gunit/opt_range-t.cc	1970-01-01 00:00:00 +0000
> +++ b/unittest/gunit/opt_range-t.cc	2011-05-12 14:41:57 +0000

> +TEST_F(SelArgTest, EqualCond)
> +{
> +  Mock_field_long field_long;
> +  EXPECT_EQ(null_tree,
> +            get_mm_tree(&m_opt_param,
> +                        new Item_equal(new Item_int(42),

There's a trailing space on the line above.

> +                                       new Item_field(&field_long))));
> +}
> +
> +}

--- Jon Olav