From: Jorgen Loland Date: May 5 2011 7:06am Subject: Re: bzr commit into mysql-trunk branch (olav.sandstaa:3368) Bug#12321461 List-Archive: http://lists.mysql.com/commits/136710 Message-Id: <4DC24C5E.8090702@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Olav, Thank you for the new patch. I have one question before approving. On 05/04/2011 03:24 PM, Olav Sandstaa wrote: > @@ -4869,7 +4869,26 @@ int DsMrr_impl::dsmrr_init(handler *h_ar > /* > We get here when the access alternates betwen MRR scan(s) and non-MRR > scans. > + */ > > + /* > + Verify consistency between the two handler objects: > + 1. The main handler should either use the primary key or not have an > + active index at this point since the clone handler (h2) is used for > + reading the index. > + 2. The index used for ICP should be the same for the two handlers or > + it should not be set on the clone handler (h2). > + 3. The ICP function should be the same for the two handlers or it should > + not be set for the clone handler (h2). In which case(s) will h but not h2 have a pushed index after the cloning has been done? -- Jørgen Løland | Senior Software Engineer | +47 73842138 Oracle MySQL Trondheim, Norway