List:Commits« Previous MessageNext Message »
From:Guilhem Bichot Date:May 2 2011 10:56am
Subject:Re: bzr commit into mysql-trunk branch (roy.lyseng:3781) Bug#56881
Bug#11764086
View as plain text  
Roy Lyseng a écrit, Le 02.05.2011 12:21:
>>
>> There is also something frightening to note: not_null_tables_cache is 
>> not, as
>> the name suggests, a cache of the return value of not_null_tables(). 
>> Depending
>> on the class, not_null_tables() may return 0, not_null_tables_cache, 
>> or some mix
>> (as in the patch). So I suggest adding a comment near the declaration of
>> Item_func::not_null_tables_cache, like
>> /// union of values returned by not_null_tables() for each argument item
> 
> It's not necessarily a union of values. What about simply:
> 
> /// Value used in calculation of result of not_null_tables()

ok
Thread
bzr commit into mysql-trunk branch (roy.lyseng:3781) Bug#56881 Bug#11764086Roy Lyseng17 Mar
  • Re: bzr commit into mysql-trunk branch (roy.lyseng:3781) Bug#56881Bug#11764086Guilhem Bichot30 Apr
    • Re: bzr commit into mysql-trunk branch (roy.lyseng:3781) Bug#56881Bug#11764086Roy Lyseng2 May
      • Re: bzr commit into mysql-trunk branch (roy.lyseng:3781) Bug#56881Bug#11764086Guilhem Bichot2 May