From: Bjorn Munch Date: April 26 2011 8:59am Subject: bzr push into mysql-5.1-mtr branch (bjorn.munch:2998 to 2999) Bug#12379923 List-Archive: http://lists.mysql.com/commits/136075 X-Bug: 12379923 Message-Id: <201104260859.p3Q8xwmw024156@khepri15.norway.sun.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit 2999 Bjorn Munch 2011-04-20 Bug #12379923 60907: MYSQL-TEST/LIB/MY/SAFEPROCESS/SAFE_PROCESS.PL USES HARDCODED SIGNAL NUMBE Replaced the hardcoded 9 with 'KILL' modified: mysql-test/lib/My/SafeProcess/safe_process.pl 2998 Bjorn Munch 2011-04-18 Bug #12365486 MTR FAILS TO FIND WARNINGS IN SERVER LOG WITH --VALGRIND COMBINED WITH --DEBUG With this combination, outoput was directed to .trace but not all parts of MTR was aware of this. Replace .err with .trace at the earliest possible place modified: mysql-test/lib/My/ConfigFactory.pm mysql-test/mysql-test-run.pl === modified file 'mysql-test/lib/My/SafeProcess/safe_process.pl' --- a/mysql-test/lib/My/SafeProcess/safe_process.pl 2007-12-20 17:39:33 +0000 +++ b/mysql-test/lib/My/SafeProcess/safe_process.pl 2011-04-20 12:58:53 +0000 @@ -94,7 +94,7 @@ eval { local $SIG{INT}= \&handle_signal; local $SIG{CHLD}= sub { message("Got signal @_"); - kill(9, -$child_pid); + kill('KILL', -$child_pid); my $ret= waitpid($child_pid, 0); if ($? & 127){ exit(65); # Killed by signal @@ -134,7 +134,7 @@ if ( $@ ) { # Use negative pid in order to kill the whole # process group # -my $ret= kill(9, -$child_pid); +my $ret= kill('KILL', -$child_pid); message("Killed child: $child_pid, ret: $ret"); if ($ret > 0) { message("Killed child: $child_pid"); No bundle (reason: useless for push emails).